linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos_defconfig: Enable PL330 DMA
Date: Thu, 31 Jul 2014 08:09:49 +0200	[thread overview]
Message-ID: <53D9DDAD.7040602@suse.de> (raw)
In-Reply-To: <1406785359-21669-1-git-send-email-tushar.b@samsung.com>

Hi Tushar,

Am 31.07.2014 07:42, schrieb Tushar Behera:
> We are getting a system hang on Arndale-Octa board if PL330_DMA is not
> enabled. The issue is related to [1].
> 
> AUDSS block provides the clock for audio DMA controller. Any operation
> on this clock requires that the clock to AUDSS block be enabled. In
> current configuration, the clock is gated during late boot process when
> all unused clocks are disabled.
> 
> When PL330_DMA is enabled, the 'apb_pclk' is enabled/disabled during
> amba_probe(). Otherwise, this clock is also disabled during late boot.
> If the AUDSS block clock is disabled by then, we get a system hang.
> 
> [1] https://lkml.org/lkml/2014/6/11/32
> 
> Signed-off-by: Tushar Behera <tushar.b@samsung.com>
> ---
>  arch/arm/configs/exynos_defconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index e07a227..c5888e8 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -109,6 +109,8 @@ CONFIG_MMC_DW_IDMAC=y
>  CONFIG_MMC_DW_EXYNOS=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_S3C=y
> +CONFIG_DMADEVICES=y
> +CONFIG_PL330_DMA=y
>  CONFIG_COMMON_CLK_MAX77686=y
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT3_FS=y

Reviewed-by: Andreas F?rber <afaerber@suse.de>

Turns out I had those enabled in my local config when testing the memory
patches on Arndale Octa.

multi_v7_defconfig has them already.

However, shouldn't Kconfig grow a dependency to enable those options
automatically for whatever driver or SoC needs them?

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

  reply	other threads:[~2014-07-31  6:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31  5:42 [PATCH] ARM: exynos_defconfig: Enable PL330 DMA Tushar Behera
2014-07-31  6:09 ` Andreas Färber [this message]
2014-07-31 14:29   ` Bartlomiej Zolnierkiewicz
2014-08-01  2:24     ` Tushar Behera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D9DDAD.7040602@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).