linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: david.vrabel@citrix.com (David Vrabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] xen/arm: introduce XENFEAT_grant_map_identity
Date: Fri, 1 Aug 2014 16:17:49 +0100	[thread overview]
Message-ID: <53DBAF9C.6080702@citrix.com> (raw)
In-Reply-To: <1406904984-16068-1-git-send-email-stefano.stabellini@eu.citrix.com>

On 01/08/14 15:56, Stefano Stabellini wrote:
> The flag tells us that the hypervisor maps a grant page to guest
> physical address == machine address of the page in addition to the
> normal grant mapping address. It is needed to properly issue cache
> maintenance operation at the completion of a DMA operation involving a
> foreign grant.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Tested-by: Denis Schneider <v1ne2go@gmail.com>
> 
> ---
> Changes in v3:
> - rename XENFEAT_grant_map_11 to XENFEAT_grant_map_identity.
> ---
>  arch/arm/xen/enlighten.c         |    6 ++++++
>  include/xen/interface/features.h |    3 +++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index b96723e..eef324f 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -262,6 +262,12 @@ static int __init xen_guest_init(void)
>  	xen_domain_type = XEN_HVM_DOMAIN;
>  
>  	xen_setup_features();
> +
> +	if (!xen_feature(XENFEAT_grant_map_identity)) {
> +		pr_warn("Please upgrade your Xen.\n"
> +				"If your platform has any non-coherent DMA devices, they won't work properly.\n");

I think:

"Non-coherent DMA devices require a hypervisor with
 XENFEAT_grant_map_identity"

Is a more helpful message.

David

  reply	other threads:[~2014-08-01 15:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 14:55 [PATCH v3 0/3] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem Stefano Stabellini
2014-08-01 14:56 ` [PATCH v3 1/3] xen/arm: introduce XENFEAT_grant_map_identity Stefano Stabellini
2014-08-01 15:17   ` David Vrabel [this message]
2014-08-01 16:53   ` [Xen-devel] " Julien Grall
2014-08-01 17:09     ` Stefano Stabellini
2014-08-01 14:56 ` [PATCH v3 2/3] xen/arm: reimplement xen_dma_unmap_page & friends Stefano Stabellini
2014-08-08 14:32   ` Stefano Stabellini
2014-08-08 14:38     ` Wei Liu
2014-08-08 14:49       ` Thomas Leonard
2014-08-08 14:54         ` Stefano Stabellini
2014-08-08 15:00         ` Wei Liu
2014-08-08 16:01           ` Thomas Leonard
2014-08-08 16:12             ` Wei Liu
2014-08-08 16:52             ` Stefano Stabellini
2014-08-01 14:56 ` [PATCH v3 3/3] xen/arm: remove mach_to_phys rbtree Stefano Stabellini
2014-08-01 15:28 ` [PATCH v3 0/3] xen/arm: fix "xen_add_mach_to_phys_entry: cannot add" problem David Vrabel
2014-08-01 16:27   ` Stefano Stabellini
2014-09-10 23:28   ` Stefano Stabellini
2014-09-11 12:55     ` David Vrabel
2014-09-11 18:31       ` Stefano Stabellini
2014-09-12  9:43         ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DBAF9C.6080702@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).