From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Wed, 6 Aug 2014 09:23:51 +0800 Subject: [RFC PATCH 03/11] PCI/MSI: Refactor pci_dev_msi_enabled() In-Reply-To: References: <1406344128-27055-1-git-send-email-wangyijing@huawei.com> <1406344128-27055-4-git-send-email-wangyijing@huawei.com> Message-ID: <53E183A7.80905@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014/8/6 6:35, Stuart Yoder wrote: > On Fri, Jul 25, 2014 at 10:08 PM, Yijing Wang wrote: >> Pci_dev_msi_enabled() is used to check whether device >> MSI/MSIX enabled. Refactor this function to suuport >> checking only device MSI or MSIX enabled. >> >> Signed-off-by: Yijing Wang > > So this patch refactors things so that checks like this: > > - if (!dev->msi_enabled) > > are moved into a function: > > + if (!pci_dev_msi_enabled(dev, MSI_TYPE)) > > Can you explain a bit more why this needed. Is it just cleanup? Hi Stuart, it's not just cleanup, because "[RFC PATCH 08/11] PCI/MSI: Introduce new struct msi_irqs and struct msi_ops" introduced struct msi_irqs, so the code will change to if (!dev->msi_irqs->msi_enabled) I think driver should not need to know the details of MSI members. So I try to rework the pci_dev_msi_enabled() to hide the detailed MSI info. Thanks! Yijing. > > . > -- Thanks! Yijing