From: ohaugan@codeaurora.org (Olav Haugan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions
Date: Tue, 12 Aug 2014 09:53:44 -0700 [thread overview]
Message-ID: <53EA4698.9020608@codeaurora.org> (raw)
In-Reply-To: <20140812013559.GA25121@laptop.dumpdata.com>
On 8/11/2014 6:35 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Aug 11, 2014 at 03:45:50PM -0700, Olav Haugan wrote:
> .. snip..
>> + for_each_sg(sg, s, nents, i) {
>> + phys_addr_t phys = page_to_phys(sg_page(s));
>> + size_t page_len = s->offset + s->length;
>> +
>> + ret = iommu_map(domain, iova + offset, phys, page_len,
>> + prot);
>> + if (ret) {
>> + /* undo mappings already done */
>> + iommu_unmap(domain, iova, offset);
>
> Don't we want then to unmap all of the scatter list instead of just
> the last one?
>
It reverts all the mapping that was already done up until the error
occurred. "offset" contains the amount we have mapped so far.
Thanks,
Olav
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-08-12 16:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 22:45 [PATCH v5 0/1] Add iommu map_sg/unmap_sg API Olav Haugan
2014-08-11 22:45 ` [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions Olav Haugan
2014-08-12 1:35 ` Konrad Rzeszutek Wilk
2014-08-12 16:53 ` Olav Haugan [this message]
2014-08-12 1:51 ` Hiroshi Doyu
2014-08-12 10:48 ` Rob Clark
2014-08-12 16:56 ` Olav Haugan
2014-08-18 14:07 ` joro at 8bytes.org
2014-08-18 18:32 ` Rob Clark
2014-08-18 20:48 ` Olav Haugan
2014-08-18 21:26 ` joro at 8bytes.org
2014-08-18 21:32 ` Olav Haugan
2014-08-12 16:55 ` Laurent Pinchart
2014-08-12 17:10 ` Olav Haugan
2014-08-18 21:55 ` Joerg Roedel
2014-08-18 22:47 ` Olav Haugan
2014-08-19 11:59 ` Joerg Roedel
2014-08-19 16:11 ` Laurent Pinchart
2014-08-19 18:40 ` Olav Haugan
2014-08-19 20:52 ` Laurent Pinchart
2014-08-20 5:21 ` Thierry Reding
2014-08-20 13:02 ` Konrad Rzeszutek Wilk
2014-08-20 14:15 ` Laurent Pinchart
2014-08-19 18:37 ` Olav Haugan
2014-09-25 17:01 ` Joerg Roedel
2014-10-06 19:02 ` Olav Haugan
2014-10-15 9:16 ` Thierry Reding
2014-10-16 17:23 ` Olav Haugan
2014-10-17 9:09 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EA4698.9020608@codeaurora.org \
--to=ohaugan@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).