From: gang.chen.5i5j@gmail.com (Chen Gang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly
Date: Wed, 13 Aug 2014 16:16:32 +0800 [thread overview]
Message-ID: <53EB1EE0.20002@gmail.com> (raw)
In-Reply-To: <CAMuHMdV_2b-A+eE--cXEFA68=72HK6mqx8+TCXRMVkyhESLYxQ@mail.gmail.com>
On 8/13/14 16:03, Geert Uytterhoeven wrote:
> CC kbuild
>
> On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index c49a775..0510a5d 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE
>> config ARCH_SUPPORTS_UPROBES
>> def_bool y
>>
>> +config CPU_LITTLE_ENDIAN
>> + depends on !CPU_BIG_ENDIAN
>> + def_bool y
>> +
>> +
>> config ARCH_HAS_DMA_SET_COHERENT_MASK
>> bool
>
> As this is a common symbol, and replicated for all affected architectures,
> I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in
> common Kconfig code instead, and make the individual architectures do a
> "select CPU_LITTLE_ENDIAN"?
>
That sounds a good idea to me.
> Also we could have "config CPU_BIG_ENDIAN", too, and error out
> if none or both are selected (can Kconfig error out?).
>
It is a good idea to me, welcome any members ideas, especially Kbuild
members' ideas, suggestions or completions.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2014-08-13 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 22:48 [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly Chen Gang
2014-08-13 5:08 ` Sam Ravnborg
2014-08-13 5:32 ` Chen Gang
2014-08-13 6:51 ` H. Peter Anvin
2014-08-13 7:44 ` Chen Gang
2014-08-13 8:03 ` Geert Uytterhoeven
2014-08-13 8:16 ` Chen Gang [this message]
2014-08-22 11:09 ` Michal Marek
2014-08-23 2:31 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EB1EE0.20002@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).