From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: PL310 cache initialization/fixup for BCM63138
Date: Wed, 13 Aug 2014 11:41:05 -0700 [thread overview]
Message-ID: <53EBB141.7050206@gmail.com> (raw)
In-Reply-To: <20140813182435.GM30401@n2100.arm.linux.org.uk>
On 08/13/2014 11:24 AM, Russell King - ARM Linux wrote:
> On Wed, Aug 13, 2014 at 11:09:19AM -0700, Florian Fainelli wrote:
>> Hi Russell, Arnd,
>>
>> The PL310 cache present on BCM63138 comes up with wrong values out of
>> reset in particular, I need to at least override the way-size to be
>> 32KiB otherwise.
>>
>> Right now, I am overriding the auxiliary control register by supplying a
>> non 0xffffffff aux_ctrl_mask to l2x0_of_init().
>>
>> Should I rather use a separate compatible string for it and perform the
>> "fixup" in a separate of_parse() callback, or in a separate fixup()
>> callback?
>>
>> Or is it recommended to keep overriding the aux_ctrl_mask as part of the
>> call to l2x0_of_init()?
>
> The correct answer is to research how to specify cache attributes in DT,
> and create an appropriate set of properties described by that, and have
> the l2x0 OF init code parse those, and create the appropriate aux control
> register values from those.
>
> I forget exactly what they are, but I do know that there is a standardised
> set of DT properties to describe the geometry of caches - I came across
> them about six months back when I worked on the L2 code.
Alright, I will take a stab at using the ePAPR cache properties.
How about PL310 specific properties such as instruction prefetc and
non-secure access, would boolean properties work for these?
Thanks!
--
Florian
next prev parent reply other threads:[~2014-08-13 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 18:09 PL310 cache initialization/fixup for BCM63138 Florian Fainelli
2014-08-13 18:24 ` Russell King - ARM Linux
2014-08-13 18:41 ` Florian Fainelli [this message]
2014-08-13 18:53 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EBB141.7050206@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox