linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: joel.schopp@amd.com (Joel Schopp)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] arm64: fix VTTBR_BADDR_MASK
Date: Tue, 19 Aug 2014 09:49:07 -0500	[thread overview]
Message-ID: <53F363E3.8060108@amd.com> (raw)
In-Reply-To: <20140819143834.GE31086@cbox>


>> The return is a value,not just an error code. Because of this returning
>> an error overloads that value.  0 just seemed like a convenient invalid
>> value to check since a vttbr_x of 0 is invalid, but returning a negative
>> error code would be as equally invalid.  If this is the only issue it
>> doesn't seem worth respinning the patch for, but I'll change it to
>> -EINVAL if for some reason a v6 is needed.
> Have you given up on doing the alignment check with the proper size on
> the pgd allocation for this patch?
Yes, I'd rather leave the extra check out of this patch.  If I were
changing the pgd allocation code I would make sure to add a check, or if
there were a static check there now I would update it for the dynamic
value from the hardware, but it seems unrelated to add several checks to
other parts of the code beyond those already in the patch.  I did leave
the functions in the headers such that checks like this could be added
when someone is updating the code for other reasons, say 4 level page
tables.

-Joel

  reply	other threads:[~2014-08-19 14:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-18 20:36 [PATCH v5] arm64: fix VTTBR_BADDR_MASK Joel Schopp
2014-08-19 12:24 ` Christoffer Dall
2014-08-19 14:23   ` Joel Schopp
2014-08-19 14:38     ` Christoffer Dall
2014-08-19 14:49       ` Joel Schopp [this message]
2014-08-19 14:59         ` Christoffer Dall
2014-08-19 15:16           ` Joel Schopp
2014-08-26 17:02 ` Marc Zyngier
2014-08-26 18:35   ` Joel Schopp
2014-08-29 10:06     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F363E3.8060108@amd.com \
    --to=joel.schopp@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).