linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards
Date: Tue, 19 Aug 2014 20:37:44 +0200	[thread overview]
Message-ID: <53F39978.3080901@suse.de> (raw)
In-Reply-To: <1408460913-13863-6-git-send-email-javier.martinez@collabora.co.uk>

Hi Javier,

Am 19.08.2014 17:08, schrieb Javier Martinez Canillas:
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index 8e50042..5b9dbb9 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -547,6 +547,8 @@
>  };
>  
>  &mmc_2 {
> +	vmmc-supply = <&tps65090_fet4>;
> +	vqmmc-supply = <&vqmmc_sdcard>;
>  	status = "okay";
>  	num-slots = <1>;
>  	supports-highspeed;
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 939f91c..dcac443 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -545,6 +545,8 @@
>  };
>  
>  &mmc_2 {
> +	vmmc-supply = <&tps65090_fet4>;
> +	vqmmc-supply = <&vqmmc_sdcard>;
>  	status = "okay";
>  	num-slots = <1>;
>  	supports-highspeed;

A convention that I picked up was to place overridden status property
first. Do your new properties really need to go before that?

Also, if you look at today's for-next, then supports-highspeed should be
cap-{sd,mmc}-highspeed, so it may be worth to rebase.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

  parent reply	other threads:[~2014-08-19 18:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19 15:08 [PATCH 0/6] Add max77802 support for Peach boards Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 1/6] ARM: dts: Add Peach Pit and Pi dts entry for max77802 PMIC Javier Martinez Canillas
2014-08-19 18:52   ` Andreas Färber
2014-08-20 10:27     ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 2/6] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board Javier Martinez Canillas
2014-09-10  4:44   ` Doug Anderson
2014-09-10  4:45     ` Doug Anderson
2014-09-10  9:00       ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 3/6] ARM: dts: add hdmi regulators for exynos5420 based peach-pit board Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 4/6] ARM: dts: Add thermistor dts fragment used by exynos based Peach boards Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards Javier Martinez Canillas
2014-08-19 16:26   ` Doug Anderson
2014-08-20  9:49     ` Javier Martinez Canillas
2014-08-19 18:37   ` Andreas Färber [this message]
2014-08-20 10:21     ` Javier Martinez Canillas
2014-08-20 10:36       ` Javier Martinez Canillas
2014-08-19 15:08 ` [PATCH 6/6] ARM: dts: Add Peach Pit and Pi dts entry for ISL29018 sensor Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F39978.3080901@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).