From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree
Date: Wed, 20 Aug 2014 14:50:30 +0200 [thread overview]
Message-ID: <53F49996.30007@suse.de> (raw)
In-Reply-To: <CAD=FV=WFP53bZAks7t9xybUxpna89Nz=KG+PQwAcxFEH0D+3mw@mail.gmail.com>
Kukjin,
Am 04.08.2014 17:22, schrieb Doug Anderson:
> On Fri, Aug 1, 2014 at 5:52 PM, Andreas F?rber <afaerber@suse.de> wrote:
>> diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
>> new file mode 100644
>> index 000000000000..f5566f84d885
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/exynos5250-spring.dts
[...]
>> + usb-hub {
>> + compatible = "smsc,usb3503a";
>> + reset-gpios = <&gpe1 0 GPIO_ACTIVE_LOW>;
>> + };
>
> Last I remember hearing about this, Julius said that the generic
> usb-hub driver didn't work right for asserting the reset line.
> Something about needing the reset at a very specific time in the USB
> enumeration, I think. Maybe it's somehow been fixed since then and
> that's why it's working?
>
> Also: you technically should have a pinctrl-0 and pinctrl-names
> referencing "hsic_reset" below to make sure the pin gets initted
> properly.
[...]
> Technically the missing pinctrl for hsic-reset is something that out
> to be fixed and we should figure out whether the reset line is
> actually working properly anyway. ...but I think this has been
> through enough spins and any additional fixup can happen later, so you
> can add my:
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
I wonder how to proceed now... Are you planning to continue inserting my
remaining snow/smdk/arndale refactoring patches [1,2,3,4] before the mmc
slot node refactoring on v3.18-next/dt-samsung branch?
I.e., should I send out a v7 rebasing either the remainder or just
Spring on top of your for-next, or should I just post new follow-up
patches to this series and wait?
I've prepared and successfully tested a patch adding the pinctrl Doug
requested above. Additionally, I have another follow-up ready, adding a
gmt,g781 temperature sensor (with v3.17-rc1 that actually works).
Also I understood that Javier is waiting for my remaining Snow bits to
be applied before sending out further Snow DT cleanups/fixes of his.
Thanks,
Andreas
[1] https://patchwork.kernel.org/patch/4664881/
[2] https://patchwork.kernel.org/patch/4664801/
[3] https://patchwork.kernel.org/patch/4664731/
[4] https://patchwork.kernel.org/patch/4664751/
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
next prev parent reply other threads:[~2014-08-20 12:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-02 0:52 [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-08-02 0:52 ` [PATCH v6 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-08-02 0:52 ` [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250 Andreas Färber
2014-08-02 4:48 ` Doug Anderson
2014-08-02 12:19 ` Tomasz Figa
2014-08-02 13:00 ` Andreas Färber
2014-08-20 13:06 ` Andreas Färber
2014-08-20 13:02 ` [PATCH v7] " Andreas Färber
2014-08-22 10:49 ` Kukjin Kim
2014-08-22 11:37 ` Andreas Färber
2014-08-22 16:14 ` Doug Anderson
2014-08-02 0:52 ` [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-08-02 4:54 ` Doug Anderson
2014-08-02 12:21 ` Tomasz Figa
2014-08-02 12:56 ` Tomasz Figa
2014-08-02 13:08 ` Andreas Färber
2014-08-02 13:09 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow Andreas Färber
2014-08-02 2:17 ` Javier Martinez Canillas
2014-08-02 0:52 ` [PATCH v6 06/10] ARM: dts: Clean up exynos5250-smdk5250 Andreas Färber
2014-08-02 12:57 ` Tomasz Figa
2014-08-02 0:52 ` [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale Andreas Färber
2014-08-02 13:02 ` Tomasz Figa
2014-08-02 13:10 ` Andreas Färber
2014-08-02 0:52 ` [PATCH v6 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale Andreas Färber
2014-08-02 0:52 ` [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-08-02 13:18 ` Tomasz Figa
2014-08-04 15:22 ` Doug Anderson
2014-08-04 17:31 ` Javier Martinez Canillas
2014-08-20 12:50 ` Andreas Färber [this message]
2014-08-02 2:34 ` [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Javier Martinez Canillas
2014-08-02 4:57 ` Doug Anderson
2014-08-02 10:25 ` Andreas Färber
2014-08-02 13:13 ` Tomasz Figa
2014-08-02 16:05 ` Andreas Färber
2014-08-04 15:42 ` Doug Anderson
2014-08-04 17:43 ` Javier Martinez Canillas
2014-08-07 8:40 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F49996.30007@suse.de \
--to=afaerber@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).