From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler
Date: Wed, 20 Aug 2014 12:11:14 -0700 [thread overview]
Message-ID: <53F4F2D2.2050600@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1408172005070.29347@knanqh.ubzr>
On 08/17/14 17:17, Nicolas Pitre wrote:
> On Sun, 17 Aug 2014, Russell King - ARM Linux wrote:
>
>> I have no problem with changing gic_raise_softirq() to use a different
>> lock, which gic_migrate_target(), and gic_set_affinity() can also use.
>> There's no need for horrid locking here, because the only thing we're
>> protecting is gic_map[] and the write to the register to trigger an
>> IPI - and nothing using gic_arch_extn has any business knowing about
>> SGIs.
>>
>> No need for these crappy sgi_map_lock() macros and all the ifdeffery.
> Those macros are there only to conditionalize the locking in
> gic_raise_softirq() because no locking what so ever is needed there when
> gic_migrate_target() is configured out. I suggested the macros to cut
> down on the #ifdefery in the code.
Ok I can resend with the sgi lock around the gic_cpu_map updating code.
Let's see how v5 goes.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-08-20 19:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 13:57 [PATCH v4] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler Stephen Boyd
2014-08-13 14:22 ` Russell King - ARM Linux
2014-08-13 14:53 ` Daniel Thompson
2014-08-13 14:55 ` Stephen Boyd
2014-08-13 15:05 ` Russell King - ARM Linux
2014-08-13 15:31 ` Stephen Boyd
2014-08-13 15:44 ` Nicolas Pitre
2014-08-17 17:32 ` Jason Cooper
2014-08-17 18:55 ` Russell King - ARM Linux
2014-08-17 19:04 ` Jason Cooper
2014-08-17 21:41 ` Russell King - ARM Linux
2014-08-18 0:17 ` Nicolas Pitre
2014-08-20 19:11 ` Stephen Boyd [this message]
2014-08-18 1:32 ` Jason Cooper
2014-08-18 0:04 ` Nicolas Pitre
2014-08-18 1:25 ` Jason Cooper
2014-08-18 1:35 ` Nicolas Pitre
2014-08-18 1:54 ` Jason Cooper
2014-08-18 2:18 ` Nicolas Pitre
2014-08-20 19:16 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4F2D2.2050600@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).