From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 26 Aug 2014 12:05:51 -0700 Subject: [PATCH v2 01/26] genirq: add irq_domain-aware core IRQ handler In-Reply-To: <53FCD60E.1030009@codeaurora.org> References: <1409047421-27649-1-git-send-email-marc.zyngier@arm.com> <1409047421-27649-2-git-send-email-marc.zyngier@arm.com> <53FCC714.3090206@codeaurora.org> <53FCCCC7.9070801@arm.com> <53FCD60E.1030009@codeaurora.org> Message-ID: <53FCDA8F.7070703@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/26/14 11:46, Stephen Boyd wrote: > On 08/26/14 11:07, Marc Zyngier wrote: >> Digging into my email, one of the traces looked like this: >> >> stack backtrace: >> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.16.0-rc1+ #135 >> Call trace: >> [] dump_backtrace+0x0/0x12c >> [] show_stack+0x10/0x1c >> [] dump_stack+0x74/0xc4 >> [] lockdep_rcu_suspicious+0xe8/0x124 >> [] irq_find_mapping+0x16c/0x198 >> [] gic_handle_irq+0x38/0xcc >> >> Most drivers call irq_find_mapping outside of irq_enter()/irq_exit(), as >> this is in handle_IRQ(). >> > Ah ok. This is the multi-irq handler case? Has this been broken since > v3.2 at least for the gic users? Now that we call irq_enter()/irq_exit() > a lot more code runs, including things like updating jiffies when > interrupts arrive and invoking softirq? Do we only call irq_exit() on > the IPI path otherwise? > > Are there any plans to send this back to stable trees? Not calling > irq_enter()/irq_exit() when we get an interrupt seems like a big problem. > Hmm I see we still call handle_IRQ eventually. So it's not as bad as I first thought. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation