From: jcm@redhat.com (Jon Masters)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] setup: Move unmask of async interrupts after possible earlycon setup
Date: Tue, 26 Aug 2014 16:05:16 -0400 [thread overview]
Message-ID: <53FCE87C.6030201@redhat.com> (raw)
In-Reply-To: <CACxGe6s_s=oufaEaaN6Hgz9rUzuGDX-c0RG_-JtYSP598FOeCw@mail.gmail.com>
Hi Grant,
On 08/26/2014 04:01 PM, Grant Likely wrote:
> On Tue, Aug 26, 2014 at 7:55 PM, Jon Masters <jcm@redhat.com> wrote:
>> The kernel wants to enable reporting of asynchronous interrupts (i.e.
>> System Errors) as early as possible. But if this happens too early
>> then a pending System Error on initial entry into the kernel will
>> never be reported where a user can see it (instead it will remain
>> in the kernel ring buffer and be visible only via hardware debug).
>> Therefore, move the enabling of asynchronous interrupts to after
>> parsing any possible earlycon parameters setting up earlycon.
>>
>> Signed-off-by: Jon Masters <jcm@redhat.com>
>
> That sounds wrong. Why aren't early log messages getting flushed out
> when the console shows up?
The problem is that when such an error occurs, we immediately panic. And
we've not setup the earlycon yet so there's no way to ever see it. I
wasted a bunch of time last week so it's worth saving someone else.
Jon.
next prev parent reply other threads:[~2014-08-26 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 18:55 [PATCH] setup: Move unmask of async interrupts after possible earlycon setup Jon Masters
2014-08-26 20:01 ` Grant Likely
2014-08-26 20:05 ` Jon Masters [this message]
2014-08-26 20:09 ` Grant Likely
2014-08-26 20:52 ` Jon Masters
2014-08-26 20:12 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCE87C.6030201@redhat.com \
--to=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).