From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables
Date: Wed, 27 Aug 2014 15:29:19 +0200 [thread overview]
Message-ID: <53FDDD2F.20503@suse.de> (raw)
In-Reply-To: <20140827055247.GC15640@ulmo>
Am 27.08.2014 07:52, schrieb Thierry Reding:
> On Wed, Aug 27, 2014 at 12:26:08AM +0200, Andreas F?rber wrote:
>> Am 25.08.2014 14:10, schrieb Mikko Perttunen:
>>> On 25/08/14 13:55, Mikko Perttunen wrote:
>>>> On 25/08/14 13:32, Andreas F?rber wrote:
>>>>> Am 22.08.2014 23:18, schrieb Stephen Warren:
>>>>>> From: Stephen Warren <swarren@nvidia.com>
>>>>>>
>>>>>> This pinmux tables currently omit any configuration for PCIe clk_req,
>>>>>> wake, and rst pins, which in turn causes intermittent failures in
>>>>>> U-Boot's PCIe support. Import an updated version of the pinmux tables
>>>>>> which rectifies this.
>>>>>>
>>>>>> (While I'm still hoping to remove the pinmux tables from DTs for
>>>>>> Tegra124+ devices, while they're still here, they may as well be
>>>>>> complete and correct).
>>>>>>
>>>>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>>>>>> ---
>>>>>> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 35
>>>>>> +++++++++++++++++++++++++++++++
>>>>>> 1 file changed, 35 insertions(+)
>>>>>
>>>>> I've tested this patch on both -rc1 and yesterday's torvalds/linux.git
>>>>> with tegra_defconfig: Both with or without this patch I get empty lspci
>>>>> output.
>>>>>
>>>>> There doesn't seem to be a tegra/linux.git for-next branch based on -rc1
>>>>> yet - are patches from other subsystem trees needed to get the on-board
>>>>> Ethernet detected or maybe some config option?
>>>>
>>>> git://gitorious.org/thierryreding/linux.git staging/pci
>>>
>>> .. and apparently the device tree patches are in staging/tegra.
>>
>> Thanks for the URLs. I tested yesterday's staging/master, but booting
>> from SD seemed broked, sdhci-tegra probe kept deferring. Is that a known
>> issue?
>
> Yes, this is a known issue. The root is that currently there's no way to
> allow deferred probing if an IOMMU hasn't been probed, so a driver needs
> to continue without IOMMU support even if the IOMMU would come up later
> in the boot process. The staging/iommu branch contains a patch to fix it
> but it looks as if that won't be merged.
>
> I've since removed the code that registers the Tegra SMMU with the code
> that I introduced but haven't removed the registry patch yet, which will
> cause the SMMU never to show up and therefore indefinitely deferring
> probe. You can easily solve this by removing the iommus property from
> the sdhci nodes in DTS or by removing the calls to iommu_attach() and
> iommu_detach() from the SDHCI driver (reverting "mmc: sdhci-tegra: Add
> IOMMU support").
>
> I'll see if I can find the time today to fix up the branches.
No hurry! I switched to testing the newly updated for-next branch, which
works fine so far (been using a USB Ethernet adapter).
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140827/fef1992e/attachment-0001.sig>
next prev parent reply other threads:[~2014-08-27 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 21:18 [PATCH] ARM: tegra: add PCIe-related pins to the Jetson TK1 pinmux tables Stephen Warren
2014-08-25 10:32 ` Andreas Färber
2014-08-25 10:55 ` Mikko Perttunen
2014-08-25 12:10 ` Mikko Perttunen
2014-08-26 22:26 ` Andreas Färber
2014-08-27 5:52 ` Thierry Reding
2014-08-27 13:29 ` Andreas Färber [this message]
2014-08-25 17:24 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDDD2F.20503@suse.de \
--to=afaerber@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).