From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7EE3C433ED for ; Thu, 22 Apr 2021 16:15:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FA0161406 for ; Thu, 22 Apr 2021 16:15:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FA0161406 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WRZzOfDp2Ggj/QC84XoAMUVhLXwYa2f5QUrmAsqDJzQ=; b=a1EftqBvvTlxIA60NTdfhyHMx 9oIi/PjWmK4cOFU4ra/CFCMyd1IN5wxxbmNVBikBB95VyqZ0Z4km8AkjtezoXE8NBRN5yEhB+ZhG5 /NV5c4mpvu7Qc50wiINH21dfn8p08YrP/vxTP2EjoL3ecGQfgA2n2NipOtEjxH3ok8I7AC3/rBkDh iGmReA4hBbrBfBgDBcOW+WXnLaQDhsGzCce5RunFpqhWuc1y0RWYiCkaZ2tOk5sn8O3dkIAKNHp2d bPMOvuOJVKID3qeG6G13rUsq2aiy6HcZ4PqkoHSlNnWhzsOJrxpHDbamhFdaurZK4VOGvcuggQS7O suQu7Rrxw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZbxG-00H22P-4n; Thu, 22 Apr 2021 16:13:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZbx7-00H21F-6G for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 16:13:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=unBNzfR/BPMqNhQLgs7hiR+1u6JHAky3xdrg8Qk4UQ0=; b=mmYv18r5RITA+NO3EL+WoSUj4m HcLGckbm5EUz9nI+oS6ulFzhAc4cMr9zABinrPN1sxZHTceXbPvcB6nEEGce0ybuDsUu9tDyR+H8s 4PwDd7WmllSxu34+gQZzUsVsdu4jD7NKC3d0aq+AfmRd1ht9FdWYPi0ZYpGh/bv/erkI+Tg1oAwJJ VjenY06sF+losEW8N2xuQ2x5J8Ffha+0fwEdRr/uVxtS8i/E9Mn+rUZCthxHZEV/ZLdFkuT04aplK wIAStF6ixJ625gUZ/Dx60JIJDuTWGqPHNuaFA256fUOk8qqrrG2782uCNJdvnIHnLGrZdlmu5PEGH EyC8q1LA==; Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZbx4-00DpUI-E1 for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 16:13:16 +0000 Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 23 Apr 2021 01:13:10 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 41E27205902A; Fri, 23 Apr 2021 01:13:10 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 23 Apr 2021 01:13:10 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by kinkan2.css.socionext.com (Postfix) with ESMTP id A76A8B1D40; Fri, 23 Apr 2021 01:13:09 +0900 (JST) Received: from [10.212.21.208] (unknown [10.212.21.208]) by yuzu2.css.socionext.com (Postfix) with ESMTP id 05A6B6270; Fri, 23 Apr 2021 01:13:08 +0900 (JST) Subject: Re: [PATCH v10 3/3] PCI: uniphier: Add misc interrupt handler to invoke PME and AER To: Bjorn Helgaas Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jassi Brar , Masami Hiramatsu References: <20210414194654.GA2526782@bjorn-Precision-5520> From: Kunihiko Hayashi Message-ID: <53a0792c-3bb8-723a-f5b0-7ef59533fad5@socionext.com> Date: Fri, 23 Apr 2021 01:13:08 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210414194654.GA2526782@bjorn-Precision-5520> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_091314_606968_3E20FA91 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bjorn, On 2021/04/15 4:46, Bjorn Helgaas wrote: > On Sat, Apr 10, 2021 at 01:22:18AM +0900, Kunihiko Hayashi wrote: >> This patch adds misc interrupt handler to detect and invoke PME/AER event. >> >> In UniPhier PCIe controller, PME/AER signals are assigned to the same >> signal as MSI by the internal logic. These signals should be detected by >> the internal register, however, DWC MSI handler can't handle these signals. >> >> DWC MSI handler calls .msi_host_isr() callback function, that detects >> PME/AER signals using the internal register and invokes the interrupt >> with PME/AER vIRQ numbers. >> >> These vIRQ numbers is obtained by uniphier_pcie_port_get_irq() function, >> that finds the device that matches PME/AER from the devices associated >> with Root Port, and returns its vIRQ number. > > Why do you use the term "vIRQ"? What exactly is a vIRQ? It seems no > different than the simple "irq" as stored in pci_dev.irq or > pcie_device.irq and passed to generic_handle_irq(). "virq" is also > used in the patch, so if you change one, please change the other as > well. Indeed, I used "virq" in contrast to "hwirq", but that seems wrong. This interrupt number is equivarent to pci_dev.irq, so I'll fix it. Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel