From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C843DC4338F for ; Wed, 25 Aug 2021 10:46:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B49E610A6 for ; Wed, 25 Aug 2021 10:46:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B49E610A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TOg0ghfKIi0/6mjIVfXqV+Elhk3+4yiyIDaBRLBkEVM=; b=P/M+0SmD5px6lJ 1H2gOyxl1ycM0fOZ15ySJPwQuOwkivuzg8EDhzORlJEi6Xg3M802q1Iasu9ClQHpuZ+UxbzIiCw2e j1neWv/9skM+ehNhUFbn0xhJI6Jg9fFDW+w7MQO1kL7qb4La5L2U1eXUICX3q+fKnvTFPQQchQgIZ AQTTKNBYfeS/cQupHLKLhzg2AXlF43idFjHr9pp0hA912Wn7uqFAXEzMUDwFd5mSTJiqjwvgWshyA pFJE7fk5ju+LPIHnWrnJPHCXMqZC12HoDT8k40NP0Pvn81NlYsQl4AHwaTbrOnO9tY6NXSD5b0Qkc 2Apr8xPq+Zjx9eoCu9Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIqNv-006bev-8k; Wed, 25 Aug 2021 10:43:55 +0000 Received: from smtprelay0003.hostedemail.com ([216.40.44.3] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIqAZ-006VNJ-DU for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 10:30:09 +0000 Received: from omf08.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id CA66B837F24A; Wed, 25 Aug 2021 10:30:03 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA id A579C1A29FA; Wed, 25 Aug 2021 10:30:01 +0000 (UTC) Message-ID: <53afc244281b6a76aecf4a5565d7e6395e376d4e.camel@perches.com> Subject: Re: [PATCH] mxser: use semi-colons instead of commas From: Joe Perches To: Dan Carpenter , Jiri Slaby , Julia Lawall Cc: Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Wed, 25 Aug 2021 03:30:00 -0700 In-Reply-To: <20210825072435.GB13013@kili> References: <20210825072435.GB13013@kili> User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 X-Stat-Signature: fhz34dbq4brzn9e34cqdugwpe39kmw6f X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: A579C1A29FA X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+5U8rMBtJFv9T/N4vofemkm0kOCT7Z/2Y= X-HE-Tag: 1629887401-102061 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_033007_574618_FC7D0FF8 X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-08-25 at 10:24 +0300, Dan Carpenter wrote: > This code works, but it's cleaner to use semi-colons at the end of > a statement instead of a comma. There are still multiple dozens of this type of comma use in the kernel. Julia Lawall created a cocci script to convert the commas to semicolons that worked pretty well. https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ > diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c [] > @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struc= t *tty, > =A0 if (closing_wait !=3D ASYNC_CLOSING_WAIT_NONE) > =A0 closing_wait =3D jiffies_to_msecs(closing_wait) / 10; > =A0 > = > - ss->type =3D info->type, > - ss->line =3D tty->index, > - ss->port =3D info->ioaddr, > - ss->irq =3D info->board->irq, > - ss->flags =3D info->port.flags, > - ss->baud_base =3D MXSER_BAUD_BASE, > + ss->type =3D info->type; > + ss->line =3D tty->index; > + ss->port =3D info->ioaddr; > + ss->irq =3D info->board->irq; > + ss->flags =3D info->port.flags; > + ss->baud_base =3D MXSER_BAUD_BASE; > =A0 ss->close_delay =3D close_delay; > =A0 ss->closing_wait =3D closing_wait; > =A0 ss->custom_divisor =3D MXSER_CUSTOM_DIVISOR, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel