From: Marc Zyngier <maz@kernel.org>
To: Shannon Zhao <shannon.zhao@linux.alibaba.com>
Cc: suzuki.poulose@arm.com, will@kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, anshuman.khandual@arm.com
Subject: Re: [PATCH] arm64: cpufeature: remove non-exist CONFIG_KVM_ARM_HOST
Date: Mon, 04 Jan 2021 12:40:46 +0000 [thread overview]
Message-ID: <53c52d0729cfc300b2cead400e2b846b@kernel.org> (raw)
In-Reply-To: <1609760324-92271-1-git-send-email-shannon.zhao@linux.alibaba.com>
On 2021-01-04 11:38, Shannon Zhao wrote:
> Commit d82755b2e781 ("KVM: arm64: Kill off CONFIG_KVM_ARM_HOST")
> deletes
> CONFIG_KVM_ARM_HOST option, it should use CONFIG_KVM instead.
>
> Just remove CONFIG_KVM_ARM_HOST here.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linux.alibaba.com>
> ---
> arch/arm64/kernel/cpufeature.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/cpufeature.c
> b/arch/arm64/kernel/cpufeature.c
> index 7ffb5f1..e99edde 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2568,7 +2568,7 @@ static void verify_hyp_capabilities(void)
> int parange, ipa_max;
> unsigned int safe_vmid_bits, vmid_bits;
>
> - if (!IS_ENABLED(CONFIG_KVM) || !IS_ENABLED(CONFIG_KVM_ARM_HOST))
> + if (!IS_ENABLED(CONFIG_KVM))
> return;
>
> safe_mmfr1 = read_sanitised_ftr_reg(SYS_ID_AA64MMFR1_EL1);
Well spotted. It means this function has never run since v5.8.
It only performs a sanity check, but still...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-04 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 11:38 [PATCH] arm64: cpufeature: remove non-exist CONFIG_KVM_ARM_HOST Shannon Zhao
2021-01-04 12:40 ` Marc Zyngier [this message]
2021-01-05 12:48 ` Catalin Marinas
2021-01-05 13:23 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53c52d0729cfc300b2cead400e2b846b@kernel.org \
--to=maz@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shannon.zhao@linux.alibaba.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).