From: Bean Huo <huobean@gmail.com>
To: Stanley Chu <stanley.chu@mediatek.com>
Cc: bjorn.andersson@linaro.org, matthias.bgg@gmail.com,
cang@codeaurora.org, alim.akhtar@samsung.com, beanhuo@micron.com,
bvanassche@acm.org, linux-scsi@vger.kernel.org,
peter.wang@mediatek.com, cc.chou@mediatek.com,
andy.teng@mediatek.com, jejb@linux.ibm.com,
chun-hung.wu@mediatek.com, nguyenb@codeaurora.org,
avri.altman@wdc.com, linux-mediatek@lists.infradead.org,
jiajie.hao@mediatek.com, chaotian.jing@mediatek.com,
linux-arm-kernel@lists.infradead.org, martin.petersen@oracle.com,
kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
alice.chao@mediatek.com, asutoshd@codeaurora.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: Re-enable WriteBooster after device reset
Date: Mon, 14 Dec 2020 21:32:57 +0100 [thread overview]
Message-ID: <53cf543b503900847ea776aa3edd24cc33252501.camel@gmail.com> (raw)
In-Reply-To: <1607476170.3580.29.camel@mtkswgap22>
On Wed, 2020-12-09 at 09:09 +0800, Stanley Chu wrote:
> > >
> > > - if (!err)
> > > + if (!err) {
> > > ufshcd_set_ufs_dev_active(hba);
> > > + if (ufshcd_is_wb_allowed(hba)) {
> > > + hba->wb_enabled = false;
> > > + hba->wb_buf_flush_enabled =
> > > false;
> > > + }
> > > + }
> >
> > Stanley,
> > how do you think group wb_buf_flush_enabled and wb_enabled to the
> > dev_info, since they are UFS device attributes. means they are set
> > only
> > when UFS device flags being set.
>
> Hi Bean,
>
> Thanks for your review.
>
> Yes, I agreed that wb related variables is a mess currently. I would
> like to clean them up once I have time. Feel free to post your patch
> if
> you want to take it up : )
>
Hi Stanley
I updated this change in my new "Several changes for UFS WriteBooster"
series patch, are you interested in reviewing that? to help Martin
easier pick up the changes.
Thanks,
Bean
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-14 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 13:56 [PATCH v2 0/2] scsi: ufs: Re-enable WB after device reset Stanley Chu
2020-12-08 13:56 ` [PATCH v2 1/2] scsi: ufs: Re-enable WriteBooster " Stanley Chu
2020-12-08 14:13 ` Bean Huo
2020-12-09 1:09 ` Stanley Chu
2020-12-14 20:32 ` Bean Huo [this message]
2020-12-08 13:56 ` [PATCH v2 2/2] scsi: ufs: Uninline ufshcd_vops_device_reset function Stanley Chu
2020-12-08 14:14 ` Bean Huo
2020-12-09 17:12 ` [PATCH v2 0/2] scsi: ufs: Re-enable WB after device reset Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53cf543b503900847ea776aa3edd24cc33252501.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=nguyenb@codeaurora.org \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).