From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 624B6E77183 for ; Mon, 16 Dec 2024 01:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J0nbcHZ7qGTE/Ol5N+bv6FAgJzDSCh3XqyaTZQ0fqJw=; b=YoHh71vfl9zRdhNoHF1q7auy6n NkpNPoKMfgXKowXusXlIeSnb4ej6E6D/zRmxRI7jol+iXlivRGwZ5cVkSZmazWozziCDsvtxe//f6 pGLORHe/J9qs2sz/jEwbz7j954jACZ9bv+At2sQrm+yQSJfgQjUlMGN0VL6VDhWczNSOQiT/OGrz4 EHTMWLOwcA2+3HVp68crtThIYhuXjvtS1ieKOCbqXKoZOOWlA8vaowPc0WFWt6bjFuHQrfXe7e75x KkzczsIjn0x9U52hjZLXJHKpjRjXVbACYsfz/ehChbmminUVWbvD7Y8Z+o/gTEHumB9j9wJHt5Gfg hNp5bqsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tMzb4-00000008jMj-2am4; Mon, 16 Dec 2024 01:08:30 +0000 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tMzZy-00000008jJP-0VJX for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2024 01:07:23 +0000 Received: from [10.172.195.16] (1.general.hwang4.uk.vpn [10.172.195.16]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id F24D940945; Mon, 16 Dec 2024 01:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1734311238; bh=J0nbcHZ7qGTE/Ol5N+bv6FAgJzDSCh3XqyaTZQ0fqJw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XMkgrCv6WEYtlac49vB7lELtJ8sUMn3I9fcSB+lvd1A0Bnn0bPggmgvZD0EaITV0v j1rZohFzToVdFuci5DPY6Xa9XFJevfcequzH2uE3E9tLqZQtqO7FXQ9Do7lDwt7ynN jYc9Vh/c3R7xXH40z8akTxn8Ni5Pg2gIc5ex7MNjha4Bb3DLLo2U/XPlOs6UjCYQ0z VFXfDPL+393UW7zfFOGHlG/DLA15M1Srcn7xurDH4ZhiCz+/LBVbtUNK8dlJmsWJTs Cbxs39TVjN/eva8RLKWScZMNGe76ioWyPYgrUzyFmC5m01cFaiQPMRrN9gd5+R9i3u GBROdfszg4Vgw== Message-ID: <53d8c4e9-0047-40f5-9142-2b3e8e723100@canonical.com> Date: Mon, 16 Dec 2024 09:07:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: nxp: imx6qdl: add dr_mode to usbotg To: Xu Yang Cc: linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com References: <20241212043126.73045-1-hui.wang@canonical.com> <20241213081729.ohgs7tyyzywd4uyc@hippo> <20241213125528.m2skucuhqtrc5f4s@hippo> Content-Language: en-US From: Hui Wang In-Reply-To: <20241213125528.m2skucuhqtrc5f4s@hippo> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241215_170722_450815_E60D7372 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/13/24 20:55, Xu Yang wrote: > On Fri, Dec 13, 2024 at 07:25:32PM +0800, Hui Wang wrote: >> On 12/13/24 16:17, Xu Yang wrote: >>> Hi, >>> >>> On Thu, Dec 12, 2024 at 12:31:26PM +0800, Hui Wang wrote: >>>> For the chipidea usb driver, if the dr_mode is not set, it will set >>>> the device to otg mode by default, so here the dr_mode has not been >>>> set for a long time. But some testcases need to parse the dr_mode from >>>> DT and decide the follow-up test strategy, here set the dr_mode to otg >>>> explicitly for QA's testcases. >>> The dr_mode is board specific property, so we normally don't put it in >>> dtsi file. Also, imx6qdl.dtsi is a common dtsi, therefore it's not a >>> correct place. I wonder you don't set dr_mode in other dts file which >>> include will imx6qdl.dtsi? >> Yes, our QA reported this issue against the imx6q-sabresd board, I thought >> dr_mode could be overwritten if board dts set the dr_mode, so this change >> will not impact existing boards. But as you said "we normally don't put it >> in dtsi file", I will move it to imx6q-sabresd.dts. > Okay. You can move it to imx6qdl-sabresd.dtsi too. Then you can reuse > &usbotg {}. Yes, for sure. Thanks, Hui. > Thanks, > Xu Yang > >> Thanks, >> >> Hui. >> >>> Thanks, >>> Xu Yang >>> >>>> Signed-off-by: Hui Wang >>>> --- >>>> arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi >>>> index d2200c9db25a..285fb7314a88 100644 >>>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi >>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi >>>> @@ -982,6 +982,7 @@ usbotg: usb@2184000 { >>>> clocks = <&clks IMX6QDL_CLK_USBOH3>; >>>> fsl,usbphy = <&usbphy1>; >>>> fsl,usbmisc = <&usbmisc 0>; >>>> + dr_mode = "otg"; >>>> ahb-burst-config = <0x0>; >>>> tx-burst-size-dword = <0x10>; >>>> rx-burst-size-dword = <0x10>; >>>> -- >>>> 2.34.1 >>>>