From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3CE4CD3427 for ; Sun, 10 May 2026 19:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8NtVp+XegjZHVec+TG++C7hqL/jdKwHQkADv6jK3v0Y=; b=29grbjb8Sc0ZAEiPMNqpRmTHl+ CUhJhTA2kwc+FfA8nytPmRzxg+nW/t2u7GpvSDztC/LbrFhNiofs2F27BM9eRRwP/1p9dC84fOm80 cDcKtVAW9dW25nx10xkc14XaAwMGup19tZnGEK5DUPEiXl1BiotxLvqP4KU6ZZ6jaFfOZp6TTJAsN Oxdik4AGqEPYm0P3KA8GuJtqoXDFXg2H/S7Pi4MjyMQigX8cQevz8kPiXF4lY/sJFf3ztiXOdZmKK n93Ysrkc7cMMfoeK2SFrVHqGl1oqCZCVOZ1YJMfzN9eW4yqzlnyOJ/qGsZDsGZ57MIiKY+GsXHsG7 A9H8Drug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wM9ab-0000000BSnV-43eX; Sun, 10 May 2026 19:13:22 +0000 Received: from smtp.forwardemail.net ([121.127.44.66]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wM9aZ-0000000BSmP-1A2N for linux-arm-kernel@lists.infradead.org; Sun, 10 May 2026 19:13:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1778440388; bh=8NtVp+XegjZHVec+TG++C7hqL/jdKwHQkADv6jK3v0Y=; b=gQucZzt3wvGaZTTC+r9JlsPRrttGYGHcogvVMqwaww+48Dbt7yi/bDRAqM1r6978vLGCYrIsr Uxz3nK2h0CKJRnOkB0U+fsQw2wAGP9YQE5A74zPsU5ibW/Boe9POqJisvzwxYcwMZrv6hBNxjFe 4geqIcKsNKzQGprG0Li/rZtBXZdhNd9vjkrGDju6K58leGrlSrhUrwnDimShoghBw95zjd0cmSj gR1ZcYBv3v4J8P8dz6MayU9lNQeahedXvB36d0yPAyj573UJMrYQxuwbKygxMV9z0z4+1KbT2SU djQ+ERW1sIrTPfIKWYHAN08u/CLOdeFT54ckpLsIXPvw== X-Forward-Email-ID: 6a00d88e8983a631c215f734 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.66 X-Forward-Email-Version: 2.8.0 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: <53e09f70-c449-49bb-b2a0-636d5d4bd395@kwiboo.se> Date: Sun, 10 May 2026 21:12:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] drm/rockchip: dw_hdmi: Apply DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector To: Damon Ding Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, wens@kernel.org, samuel@sholland.org, luca.ceresoli@bootlin.com, Laurent.pinchart@ideasonboard.com, jernej.skrabec@gmail.com, victor.liu@nxp.com, dmitry.baryshkov@oss.qualcomm.com, shengjiu.wang@nxp.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20260403070032.447102-1-damon.ding@rock-chips.com> <20260403070032.447102-4-damon.ding@rock-chips.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20260403070032.447102-4-damon.ding@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260510_121319_480374_F962717C X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Damon, On 4/3/2026 9:00 AM, Damon Ding wrote: > Convert this driver to DRM_BRIDGE_ATTACH_NO_CONNECTOR and to the > drm_bridge_connector framework which is the current DRM bridge best > practice. Changing to use the bridge connector at this stage will cause the Rockchip platform to drop features the dw-hdmi connector currently only can provide, e.g. a CEC notifier, some connector properties and more. I am also currently working on a multi series effort to: - phy: rockchip: inno-hdmi: Change TMDS rate handling to configure() ops [v2] - drm/rockchip: dw_hdmi: Misc cleanup and propagate bus format [v1] - drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup [v5] - drm/bridge: dw-hdmi: Improve input/output bus format handling - drm/bridge: dw-hdmi: Convert to a HDMI bridge and use of bridge connector - drm/bridge: dw-hdmi: Add and use tmds_char_rate_valid() plat data ops - drm/meson: hdmi: Misc cleanup and use CEC notifier helpers - drm/rockchip: dw_hdmi: Enable YCbCr and Deep Color modes Link to snapshot: https://github.com/Kwiboo/linux-rockchip/commits/next-20260508-rk-hdmi-v3/ Part of that effort include to fully convert the dw-hdmi bridge into a HDMI bridge, something that is required to fully be able to replace all features currently provided by the use of the dw-hdmi connector. In that effort I have also taken a different approach and instead replace the dw-hdmi connector with the bridge connector directly from inside the dw-hdmi bridge driver. Regards, Jonas > Signed-off-by: Damon Ding > --- > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 19 +++++++++++++++---- > 2 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index e7f49fe845ea..69b832d0c8c4 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -76,6 +76,7 @@ config ROCKCHIP_DW_DP > > config ROCKCHIP_DW_HDMI > bool "Rockchip specific extensions for Synopsys DW HDMI" > + select DRM_BRIDGE_CONNECTOR > help > This selects support for Rockchip SoC specific extensions > for the Synopsys DesignWare HDMI driver. If you want to > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index 21b141b7cb9c..b5cfcb936078 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -13,6 +13,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -542,6 +543,7 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > struct drm_device *drm = data; > struct drm_encoder *encoder; > struct rockchip_hdmi *hdmi; > + struct drm_connector *connector; > int ret; > > if (!pdev->dev.of_node) > @@ -608,7 +610,7 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > > platform_set_drvdata(pdev, hdmi); > > - hdmi->hdmi = dw_hdmi_bind(pdev, encoder, plat_data, 0); > + hdmi->hdmi = dw_hdmi_bind(pdev, encoder, plat_data, DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > /* > * If dw_hdmi_bind() fails we'll never call dw_hdmi_unbind(), > @@ -616,12 +618,21 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > */ > if (IS_ERR(hdmi->hdmi)) { > ret = PTR_ERR(hdmi->hdmi); > - goto err_bind; > + goto err_cleanup_encoder; > } > > - return 0; > + connector = drm_bridge_connector_init(drm, encoder); > + if (IS_ERR(connector)) { > + ret = PTR_ERR(connector); > + dev_err(hdmi->dev, "Failed to initialize bridge_connector\n"); > + goto err_unbind_bridge; > + } > > -err_bind: > + return drm_connector_attach_encoder(connector, encoder); > + > +err_unbind_bridge: > + dw_hdmi_unbind(hdmi->hdmi); > +err_cleanup_encoder: > drm_encoder_cleanup(encoder); > > return ret;