Re: [PATCH v3 0/5] Upstreaming Pinephone Pro Patches

[Dragan Simic <dsimic@manjaro.org>]

Hello Rudraksha,

On 2025-09-21 23:05, Rudraksha Gupta via B4 Relay wrote:
> Throughout the years, many have contributed to the Pinephone Pro (ppp)
> development. Unfortunately, these patches are scattered around various
> repositories in different states.

Thanks for submitting these patches.  However, please expand the patch
descriptions, because their current forms are too terse and, as such,
simply not acceptable.  This applies to all patches in this series.

I'm also under impression that you're submitting these patches upstream
blindly and without researching the rules that apply well enough, which
may not be the best possible approach.

Finally, please refrain yourself from sending multiple versions of the
same patch series in the same day.  Doing so makes reviewing the patches
unnecessarily hard.

> I will be attempting to upstream these patches. I will start off with 
> the
> following small series:
> - Add light/proximity sensor support
>   - 
> https://codeberg.org/megi/linux/commit/f171bc7013bc7ad3de9af817bfbcbfa548ebe01c
> - Add accelerometer sensor support
>   - 
> https://codeberg.org/megi/linux/commit/b0bb7633e073a6760fa213b8c4a78ea2e73c7bf1
> - Add magnetometer sensor support
>   - 
> https://codeberg.org/megi/linux/commit/2f7e67f451f16eaf15b81aa1dbdf126d54927d35
> - Add mount-matrix for magnetometer
>   - 
> https://codeberg.org/megi/linux/commit/d7cd2eab931e32fa94408a96d73b4e6c0616107a
> - Fix voltage threshold for volume down key
>   - 
> https://codeberg.org/megi/linux/commit/7c496a5cc27ed4e38b740f36c2d8b2c62f80ae54
> 
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> Changes in v3:
> - change magnetometer mount matrix
> - update volume button threshold
> - Link to v2:
> https://lore.kernel.org/r/20250921-ppp_light_accel_mag_vol-down-v2-0-e6bcc6ca74ae@gmail.com
> 
> Changes in v2:
> - remove usb-typec node in dts from light/proximity sensor patch
> - Link to v1:
> https://lore.kernel.org/r/20250920-ppp_light_accel_mag_vol-down-v1-0-c8bbcd3e2e94@gmail.com
> 
> ---
> Leonardo G. Trombetta (1):
>       arm64: dts: rk3399-pinephone-pro: Add mount-matrix for 
> magnetometer
> 
> Ondrej Jirman (4):
>       arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor 
> support
>       arm64: dts: rk3399-pinephone-pro: Add accelerometer sensor 
> support
>       arm64: dts: rk3399-pinephone-pro: Add magnetometer sensor support
>       arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for 
> volume keys
> 
>  .../boot/dts/rockchip/rk3399-pinephone-pro.dts     | 42 
> ++++++++++++++++++++--
>  1 file changed, 40 insertions(+), 2 deletions(-)