From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F43C433DF for ; Wed, 26 Aug 2020 10:33:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ADB020786 for ; Wed, 26 Aug 2020 10:33:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oKc7k2yc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="aHOapJ/z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ADB020786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4G9pdY9rjQCQDkK2SgdUPH8/2EBZ2pVR3Ld+XTy/2ms=; b=oKc7k2yclyhXmhlrf9AaM6QVY f37izjnCqNYhzCm8yTOS+vyRrTWiSvrunerIQ60QiHh8WIJbRNG08YlOh4u1dL+kDRiubd0QkSVCx wP/7603IXgMNAmlUeEedSQ7t17a3bzTDjDexJsq39R2aC+QVoRsr6/rNmoSetUJ5q7Tcf3XtuCysq cyRubSwQI29xMkEAviap//gx1a93S46ixv5CfHRFdAH/we4iFdDpcWKRAIZc4Io26Bymx+GPDm/+J pRfIzMke+B+NLvzGO/ds3mUd2/fG0If8z1HBK1Ym5AElM1by3EkZ0LA1Jd3u+v09Dwvuo2H6JOQSL Dx0SZF0Lg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAsjF-0006yi-6T; Wed, 26 Aug 2020 10:32:29 +0000 Received: from mx1.tq-group.com ([62.157.118.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAsjB-0006yE-Fx for linux-arm-kernel@lists.infradead.org; Wed, 26 Aug 2020 10:32:26 +0000 IronPort-SDR: 9OZKk8jEcvCf/m3dpFJVwSgODe4S/NTgM3/BJZwc+totVibwYjJskgkHIvH1luqMNDHkMlI4mG zgIlbku+Y8eVt0IikwZWK+8XhVAfuuhKfvo6Ykxhyaft6JuOexl8+hqdSIl5NVP1hXwUYj/llX S9Mpzl0lQ8EnZP5QpWa7B2qjdM1zHr9E+qiXNuF//7nrNIEtiTi98bUk0+cgpPYPIbLWHAkd+y Ey93PlVoyr/4vvUSnPoGqUh+eUd1OoVQeFv4fVl+ket3cgLTjv0cxIWJmbgrBGi0KCaLtL26GJ i24= X-IronPort-AV: E=Sophos;i="5.76,355,1592863200"; d="scan'208";a="13605981" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 26 Aug 2020 12:32:19 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 26 Aug 2020 12:32:19 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 26 Aug 2020 12:32:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1598437939; x=1629973939; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=mkEkX1GM1xbLiXkLbImdPglocH+IeXx6MxzXdXmSuoQ=; b=aHOapJ/zO9nEki7v7TnwPsS+h5yF6dMfYpoCz7nMFPhgXVt57jJp3gvm B1IH2vznv7YhNG3U0pd5ex5+BqQd2NkyxNP0CzE+ZS+Hk286HOIjqWRuJ qvlGBrulS8FVddQszJtWFnl7Ois8VRJQek7K7DiKE4GVNEWj7254/fF/m TLwlO5Eij84qVg/stvnBtQOEJQHOlUN4MeaPs4bbmpQy77l2ycOf70PtJ 6rltUbvoVBDt+O9In/roV7A143w5TX3x7QDf1njCQxZFLyBKLDuwYS9gi 8r/xEWF1YlOZofGI9CRAffjzjsNMukrN55vDoOcHOtlJnywwPWru8hkOM g==; IronPort-SDR: YJeyxRPZU91peRDZT+5Vm5Z4NR4Ycx+N+xtKloknBbXfhabJim5XpCZLDn9YzBXcE4nYPq0kKu y0rzgEi0Y0MefjCCBwAjS/YRoF3JNbxoOFeAuEU++hmnORUiwzvBVX1dWNqGDUFw7TjwBVclyb 8F8TaH874gCnt/7gCtT0UTlWf4KmIlz3pQLYsR+kcF1wCVqJOe64CdoYyB71/kJLAzFMirSRCE hz+NXVb+ZIsWJkOPbfYo7W8qH2UqejHbxLKhqnojoD0cK07w2E9bm9/V8PqkTJf7QS//C+PVLB 7kA= X-IronPort-AV: E=Sophos;i="5.76,355,1592863200"; d="scan'208";a="13605980" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 26 Aug 2020 12:32:19 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.117.49.26]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id B4B6A2800A2; Wed, 26 Aug 2020 12:32:19 +0200 (CEST) Message-ID: <53f5f17735fc2f0ca061a321969bbb131e55efff.camel@ew.tq-group.com> Subject: Re: (EXT) Re: (EXT) Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes From: Matthias Schiffer To: Fabio Estevam Date: Wed, 26 Aug 2020 12:32:17 +0200 In-Reply-To: References: <20200824091013.20640-1-matthias.schiffer@ew.tq-group.com> <20200824091013.20640-2-matthias.schiffer@ew.tq-group.com> <4b7d57738ce8e2130c4740a0f3f973fbaf60a7cf.camel@ew.tq-group.com> <7a59492e46f34d213b83f7182c7db73954c5a9c7.camel@ew.tq-group.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200826_063225_854972_925B211B X-CRM114-Status: GOOD ( 22.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sascha Hauer , linux-kernel , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-08-25 at 14:16 -0300, Fabio Estevam wrote: > On Tue, Aug 25, 2020 at 11:40 AM Matthias Schiffer > wrote: > > > Makes sense. Does the following logic sound correct? > > > > - If num-cs is set, use that (and add it to the docs) > > I would not add num-cs to the docs. As far as I can see there is no > imx dts that uses num-cs currently. But the previous platform data that was removed in 8cdcd8aeee281 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors") set different values for different boards. So maybe some DTS should be using num-cs? > > > - If num-cs is unset, use the number of cs-gpios > > - If num-cs is unset and no cs-gpios are defined, use a driver- > > provided > > default > > > > > > I'm not sure if 3 is a particularly useful default either, but it > > seems > > it was chosen to accommodate boards that previously set this via > > platform data. All SoCs I've checked (i.MX6Q/DL, i.MX6UL, i.MX7) > > have 4 > > internal CS pins per ECSPI instance, so maybe the driver should use > > that as its default instead? > > I think it is time to get rid of i.MX board files. I will try to work > on this when I have a chance. > > bout using 4 as default chip select number, please also check some > older SoCs like imx25, imx35, imx51, imx53, etc Hmm, I just checked i.MX28, and it has only 3 chip selects per instance. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel