linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: huangtao@rock-chips.com (Huang Tao)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc
Date: Fri, 29 Aug 2014 19:44:33 +0800	[thread overview]
Message-ID: <540067A1.6090005@rock-chips.com> (raw)
In-Reply-To: <20140829112242.GC21473@leverpostej>

Hi,

? 2014?08?29? 19:22, Mark Rutland ??:
>> ? 2014?08?28? 23:11, Mark Rutland ??:
>>> To clarify: if there are low power states that the CPU can enter where
>>> we lose state, then this patch isn't correct.
>> Right now, the software of RK3288 SoC only support CPU hotplug
>> (cpu_on/off) and power off all CPUs on suspend.
> Sure, but that's a Linux implementation detail rather than a fixed
> property of the hardware. Given those states exist, the "always-on"
> property is not appropriate.
>
>> We do not implement cpuidle to power off CPU. Do you think we should
>> introduce a broadcast timer?
> If one is present, yes. 
>
>> On our early kernel, I never see any interrupt on a broadcast timer
>> (yes, we implement it with a external timer).
> That's fine; Linux doesn't need to use it just yet. However, when we
> want to use low power states later, it will be necessary to enable
> placing all CPUS into a low power state.
>
> If your external timer is already supported by an existing driver, there
> is no reason not to add it now.
>
>>> A more general approach would be to enable the broadcast hrtimer for
>>> arm, as has been done for arm64.
>> Yes. I think it should be done by arm framework.
> Patches welcome.
>
> I also think it would make sense to enable this for arm.
>
> Thanks,
> Mark.
>
>
Okay, so this patch is wrong as I expected.
Thank you!

      reply	other threads:[~2014-08-29 11:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28  1:40 [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc Kever Yang
2014-08-28  9:17 ` Mark Rutland
2014-08-28 15:11   ` Mark Rutland
2014-08-29  0:35     ` Kever Yang
2014-08-29  3:06     ` Huang Tao
2014-08-29 11:22       ` Mark Rutland
2014-08-29 11:44         ` Huang Tao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540067A1.6090005@rock-chips.com \
    --to=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).