linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Kirkwood: Fix DT based DSA.
Date: Sun, 31 Aug 2014 13:15:05 -0700	[thread overview]
Message-ID: <54038249.4080403@gmail.com> (raw)
In-Reply-To: <1409417668-7169-1-git-send-email-andrew@lunn.ch>

On 08/30/14 09:54, Andrew Lunn wrote:
> During the conversion of boards to use DT to instantiate Distributed
> Switch Architecture, nobody volunteered to test. As to be expected,
> the conversion was flawed. Testers and access to hardware has now
> become available, and this patch hopefully fixes the problems.
>
> dsa,mii-bus must be a phandle to the top level mdio node, not the port
> specific subnode of the mdio device.
>
> dsa,ethernet must be a phandle to the port subnode within the ethernet
> DT node, not the ethernet node.
>
> Fixes: e2eaa339af441b3d51cdaa16870065c4154ce13c
> Fixes: e7c8f3808be854379c9784745663a55371cbf232

Your changes look good with respect to how the binding is defined.

>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---

[snip]

>   &eth0 {
> @@ -148,6 +142,7 @@
>   &eth1 {
>   	status = "okay";
>   	ethernet1-port at 0 {
> -		phy-handle = <&ethphy1>;
> +		speed = <1000>;
> +		duple = <1>;

Typo here: should be "duplex".

>   	};
>   };
> diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
> index afc640cd80c5..464f09a1a4a5 100644
> --- a/arch/arm/boot/dts/kirkwood.dtsi
> +++ b/arch/arm/boot/dts/kirkwood.dtsi
> @@ -309,7 +309,7 @@
>   			marvell,tx-checksum-limit = <1600>;
>   			status = "disabled";
>
> -			ethernet0-port at 0 {
> +			eth0port: ethernet0-port at 0 {
>   				compatible = "marvell,kirkwood-eth-port";
>   				reg = <0>;
>   				interrupts = <11>;
> @@ -342,7 +342,7 @@
>   			pinctrl-names = "default";
>   			status = "disabled";
>
> -			ethernet1-port at 0 {
> +			eth1port: ethernet1-port at 0 {
>   				compatible = "marvell,kirkwood-eth-port";
>   				reg = <0>;
>   				interrupts = <15>;
>

      reply	other threads:[~2014-08-31 20:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30 16:54 [PATCH] ARM: Kirkwood: Fix DT based DSA Andrew Lunn
2014-08-31 20:15 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54038249.4080403@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).