public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: list-09_linux_arm@tqsc.de (Markus Niebel)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG] staging: imx-drm: clock reparent fails for LDB channel 1 on i.MX53
Date: Wed, 03 Sep 2014 18:35:37 +0200	[thread overview]
Message-ID: <54074359.5090500@tqsc.de> (raw)

Hello,

playing with LVDS channel 1 on a TQMa53 with MBa53 mainboard we see error

imx-ldb 53fa8008.ldb: unable to set di0 parent clock to ldb_di1

this comes from imx_ldb_set_clock with mux = 0. If setting mux parameter hard to "1"
LVDS on channel 1 works just fine. The value of the mux param comes from device tree
port settings. 

The following device tree change fixes the issue, but im not sure if this is the
correct way. 

diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 6456a00..acdfabf 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -419,10 +419,14 @@
                                status = "disabled";
 
                                lvds-channel at 0 {
+                                       #address-cells = <1>;
+                                       #size-cells = <0>;
                                        reg = <0>;
                                        status = "disabled";
 
                                        port {
+                                               reg = <0>;
+
                                                lvds0_in: endpoint {
                                                        remote-endpoint = <&ipu_di0_lvds0>;
                                                };
@@ -430,10 +434,14 @@
                                };
 
                                lvds-channel at 1 {
+                                       #address-cells = <1>;
+                                       #size-cells = <0>;
                                        reg = <1>;
                                        status = "disabled";
 
                                        port {
+                                               reg = <1>;
+
                                                lvds1_in: endpoint {
                                                        remote-endpoint = <&ipu_di1_lvds1>;
                                                };
 
In my understanding the i.MX53 has no multiplexer for the input, so
DI1 -> LVDS1 in case of single channel or separate channels 

Markus Niebel

             reply	other threads:[~2014-09-03 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03 16:35 Markus Niebel [this message]
2014-09-03 16:48 ` [BUG] staging: imx-drm: clock reparent fails for LDB channel 1 on i.MX53 Fabio Estevam
2014-09-04 11:00   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54074359.5090500@tqsc.de \
    --to=list-09_linux_arm@tqsc.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox