linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch net-next 04/11] net:fec: add multiqueue support
Date: Wed, 03 Sep 2014 14:27:21 -0700	[thread overview]
Message-ID: <540787B9.8090504@gmail.com> (raw)
In-Reply-To: <1409776697-1536-5-git-send-email-Frank.Li@freescale.com>

On 09/03/2014 01:38 PM, Frank Li wrote:
> From: Fugang Duan <B38611@freescale.com>
> 
> Add multiqueue support, which is compatible with previous single queue
> driver for FEC/ENET IPs.
> 
> By default, the tx/rx queue number is 1, user can config the queue number
> at DTS file like this:
> 	fsl,num_tx_queues=<3>;
> 	fsl,num_rx_queues=<3>;
> 
> Ethernet multiqueue mechanism can improve performance in SMP system.
> For single hw queue, multiqueue can balance cpu loading.
> For multi hw queues, multiple cores can process network packets in parallel,
> and refer the article for the detail advantage for multiqueue:
> http://vger.kernel.org/~davem/davem_nyc09.pdf

You should probably split that patch in a minimum of two, or more
different parts.

Two parts:

- add TX multiqueue support
- add RX multiqueue support

More parts:

- prepare for TX multiqueue (introduce queue structure, definitions)
- transition TX path to use queue 0
- add support for the two other TX queues
- prepare for RX multiqueue (introduce queue structure, definitions)
- prepare for multiqueue, hardcode RX path to use queue 0
- add support for the two other RX queues

The number of changes are extremely hard to review...
--
Florian

  parent reply	other threads:[~2014-09-03 21:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1409776697-1536-1-git-send-email-Frank.Li@freescale.com>
     [not found] ` <1409776697-1536-4-git-send-email-Frank.Li@freescale.com>
2014-09-03 21:20   ` [Patch net-next 03/11] net:fec: use multiqueue interface to allocate Ethernet device Florian Fainelli
     [not found] ` <1409776697-1536-5-git-send-email-Frank.Li@freescale.com>
2014-09-03 21:27   ` Florian Fainelli [this message]
2014-09-04  3:41     ` [Patch net-next 04/11] net:fec: add multiqueue support Zhi Li
2014-09-04  4:09       ` Florian Fainelli
2014-09-04 14:02         ` Zhi Li
     [not found] ` <1409776697-1536-9-git-send-email-Frank.Li@freescale.com>
2014-09-04  8:50   ` [Patch net-next 08/11] net:fec: change FEC alignment to 64 bytes for ARM platform David Laight
2014-09-04  9:11     ` fugang.duan at freescale.com
2014-09-04  9:18       ` David Laight
2014-09-04 14:17         ` Zhi Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540787B9.8090504@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).