From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: omap5.dtsi: add DSS RFBI node
Date: Thu, 4 Sep 2014 08:44:48 -0500 [thread overview]
Message-ID: <54086CD0.7000203@ti.com> (raw)
In-Reply-To: <1409812112-19194-1-git-send-email-tomi.valkeinen@ti.com>
$subject: ARM: dts: OMAP5: Add DSS RFBI node
On 09/04/2014 01:28 AM, Tomi Valkeinen wrote:
> The RFBI node for OMAP DSS was left out when adding the rest of the DSS
> nodes, because it was not clear how to set up the clocks for the RFBI.
>
> However, it seems that if there is a HWMOD for a device, we also need a
> DT node for it. Otherwise, at boot, we get:
>
> WARNING: CPU: 0 PID: 1 at arch/arm/mach-omap2/omap_hwmod.c:2542 _init+0x464/0x4e0()
> omap_hwmod: dss_rfbi: doesn't have mpu register target base
>
> Now that v3.17-rc3 contains a fix
> (8fd46439e1f5a7f86d76a08733459b74debd9468) for the L3 ICLK required by
> the RFBI, let's add the RFBI node to get rid of the warning.
The usual style is to use the following style:
Commit 8fd46439e1f5 ("ARM: dts: omap54xx-clocks: Fix the l3 and l4
clock rates")
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> arch/arm/boot/dts/omap5.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index fc8df1739f39..1e6ff61a7f12 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -945,6 +945,15 @@
> clock-names = "fck";
> };
>
> + rfbi: encoder at 58002000 {
> + compatible = "ti,omap5-rfbi";
> + reg = <0x58002000 0x100>;
> + status = "disabled";
> + ti,hwmods = "dss_rfbi";
> + clocks = <&dss_dss_clk>, <&l3_iclk_div>;
> + clock-names = "fck", "ick";
> + };
> +
> dsi1: encoder at 58004000 {
> compatible = "ti,omap5-dsi";
> reg = <0x58004000 0x200>,
>
before-omap5-evm: http://paste.ubuntu.org.cn/1477659
after-omap5-evm: http://paste.ubuntu.org.cn/1477658
So, yep, no more warning.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-09-04 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 6:28 [PATCH] ARM: dts: omap5.dtsi: add DSS RFBI node Tomi Valkeinen
2014-09-04 13:44 ` Nishanth Menon [this message]
2014-09-09 0:14 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54086CD0.7000203@ti.com \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).