linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] pinctrl: at91: add drive strength configuration
Date: Fri, 5 Sep 2014 09:56:02 +0200	[thread overview]
Message-ID: <54096C92.7020205@atmel.com> (raw)
In-Reply-To: <CACRpkdagLTaumFH_rzYzvW1+TSwwN+ABBdCeH9qrLwXpyu0dJg@mail.gmail.com>

On 05/09/2014 09:33, Linus Walleij :
> On Sun, Aug 24, 2014 at 5:12 AM, Marek Roszko <mark.roszko@gmail.com> wrote:
> 
>> The SAMA5 and SAM9x5 series both have drive strength options for the PIOs. This
>> patch adds the ability to set one of three hardware options for drive strengths of low,
>> medium or high for the each pin. The actual current output of the chip based on the setting
>> is defined in the datasheets and varies per pins separate from banks and with supply voltage.
>>
>> This patch adds three new dt-bindings that allow setting the strength when configuring
>> pins. By default, no change will be made to the drive strength of a pin from its reset value.
>> Due to the difference between the register addresses of the SAMA5 and SAM9x5 series, a new
>> sama5d3-pinctrl id was added.
>>
>> Signed-off-by: Marek Roszko <mark.roszko@gmail.com>
>>
>> ---
>> changes from v1:
>> rebased to latest pinctrl
>> added requested comments
>> fix oversight in shift logic(off by 1)
> 
> Tentatively applied this patch so we get some rotation in linux-next.

After reading the comments made back in January during first submission
of this feature, it seems that there was a consensus on this patch series.
After a quick look at the new version, the comments and needed
documentation has been added: Thanks Marek!

So, if it can help, you have my:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

On the whole series. I will certainly take the AT91 compatible string
addition with my tree as well (patch 2/3).

Thanks to both of you, bye,
-- 
Nicolas Ferre

      reply	other threads:[~2014-09-05  7:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24  3:12 [PATCH v2 1/3] pinctrl: at91: add drive strength configuration Marek Roszko
2014-08-24  3:12 ` [PATCH v2 2/3] ARM: at91/dt: at91: use new pinctrl id for sama5 Marek Roszko
2014-09-05  7:34   ` Linus Walleij
2014-09-08  8:07   ` Nicolas Ferre
2014-09-18 15:32     ` Nicolas Ferre
2014-08-24  3:12 ` [PATCH v2 3/3] pinctrl: at91: update documentation for drive strength options and tweaks Marek Roszko
2014-09-05  7:36   ` Linus Walleij
2014-09-01  8:27 ` [PATCH v2 1/3] pinctrl: at91: add drive strength configuration Linus Walleij
2014-09-01  8:28   ` Jean-Christophe PLAGNIOL-VILLARD
2014-09-05  7:33 ` Linus Walleij
2014-09-05  7:56   ` Nicolas Ferre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54096C92.7020205@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).