From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: pcf8563: fix uninitialized use warning
Date: Mon, 08 Sep 2014 19:40:33 +0400 [thread overview]
Message-ID: <540DCDF1.5060008@cogentembedded.com> (raw)
In-Reply-To: <10094879.uvjB4Q3B81@wuerfel>
On 9/8/2014 7:22 PM, Arnd Bergmann wrote:
>>> diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
>>> index 5a197d9dc7e7..3a6f994c4da8 100644
>>> --- a/drivers/rtc/rtc-pcf8563.c
>>> +++ b/drivers/rtc/rtc-pcf8563.c
>>> @@ -167,7 +167,7 @@ static irqreturn_t pcf8563_irq(int irq, void *dev_id)
>>> char pending;
>>>
>>> err = pcf8563_get_alarm_mode(pcf8563->client, NULL, &pending);
>>> - if (err < 0)
>>> + if (err)
>>> return err;
>> Returning negative values from the IRQ handler doesn't seem valid.
>> Arbitrary positive value aren't good either. Perhaps should return IRQ_NONE
>> instead?
> Good point. This is unrelated to the problem I was trying to fix, but it
> seems like a good idea to fix both.
Then it would be good if you fix this issue with a separate patch.
> Arnd
WBR, Sergei
prev parent reply other threads:[~2014-09-08 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 20:42 [PATCH] rtc: pcf8563: fix uninitialized use warning Arnd Bergmann
2014-09-08 11:02 ` Sergei Shtylyov
2014-09-08 15:22 ` Arnd Bergmann
2014-09-08 15:40 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540DCDF1.5060008@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).