From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomi.valkeinen@ti.com (Tomi Valkeinen) Date: Tue, 9 Sep 2014 13:58:53 +0300 Subject: [PATCH] video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT In-Reply-To: <4032283.arT8F9Ogcl@wuerfel> References: <4032283.arT8F9Ogcl@wuerfel> Message-ID: <540EDD6D.6070704@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/09/14 18:17, Arnd Bergmann wrote: > Commit 7edaa761ee81b ("video: mx3fb: Add backlight control support") > changed the mx3fb driver so it always selects the BACKLIGHT_CLASS_DEVICE > symbol, but that is hidden behind BACKLIGHT_LCD_SUPPORT in Kconfig, so > we get a Kconfig warning for multi_v5_defconfig, which doesn't have that: > > Warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 && > DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY > && FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI && > EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE > which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT) > > This makes sure we always enable both symbols together for mx3fb, like > we do for the other drivers that can't be built without backlight > support. Note that a better solution would be to ensure the driver can > work with or without backlight support. > > Signed-off-by: Arnd Bergmann > Cc: Alexander Stein > Cc: Tomi Valkeinen > Cc: linux-fbdev at vger.kernel.org > Cc: Jean-Christophe Plagniol-Villard > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index ccbe2ae22ac5..c7bf606a8706 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2356,10 +2356,11 @@ config FB_MSM > config FB_MX3 > tristate "MX3 Framebuffer support" > depends on FB && MX3_IPU > + select BACKLIGHT_CLASS_DEVICE > + select BACKLIGHT_LCD_SUPPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > - select BACKLIGHT_CLASS_DEVICE > default y > help > This is a framebuffer device for the i.MX31 LCD Controller. So > Thanks, queued for 3.18. Tomi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: