From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: don't use __initconst for non-const arrays
Date: Thu, 11 Sep 2014 23:48:12 +0200 [thread overview]
Message-ID: <5412189C.2040802@gmail.com> (raw)
In-Reply-To: <1410469471-31027-1-git-send-email-u.kleine-koenig@pengutronix.de>
[adding Sylwester and removing my samsung.com e-mail which is no longer
valid]
On 11.09.2014 23:04, Uwe Kleine-K?nig wrote:
> The statement
>
> static const char *name[];
>
> defines a modifiable array of pointers to constant chars. That is
>
> *name[0] = 'f';
>
> is forbidden, but
>
> name[0] = "f";
>
> is not. So marking an array that is defined as above with __initconst is
> wrong. Either an additional const must be added such that the whole
> definition reads:
>
> static const char *const name[] __initconst;
>
> or where this is not possible __initdata must be used.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> drivers/clk/hisilicon/clk-hix5hd2.c | 6 ++--
> drivers/clk/mxs/clk-imx23.c | 12 ++++----
> drivers/clk/mxs/clk-imx28.c | 18 ++++++------
> drivers/clk/rockchip/clk.h | 2 +-
> drivers/clk/samsung/clk-s5pv210.c | 56 ++++++++++++++++++-------------------
For drivers/clk/samsung/*
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2014-09-11 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 21:04 [PATCH] clk: don't use __initconst for non-const arrays Uwe Kleine-König
2014-09-11 21:48 ` Tomasz Figa [this message]
2014-09-11 22:04 ` Uwe Kleine-König
2014-09-12 7:42 ` Ard Biesheuvel
2014-09-12 7:59 ` Uwe Kleine-König
-- strict thread matches above, loose matches on Subject: below --
2015-02-18 9:59 Uwe Kleine-König
2015-03-25 10:41 ` Uwe Kleine-König
2015-04-13 0:20 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412189C.2040802@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).