* [PATCH v2] soc: ti: qmss: fix the case when !SMP
@ 2016-11-30 16:53 Grygorii Strashko
2016-11-30 17:09 ` Grygorii Strashko
0 siblings, 1 reply; 4+ messages in thread
From: Grygorii Strashko @ 2016-11-30 16:53 UTC (permalink / raw)
To: linux-arm-kernel
The irq_set_affinity_hint() will always fail when !SMP and
Networking will fail on Keystone 2 devices in this case.
Hence, fix by ignoring IRQ affinity settings when !SMP.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/soc/ti/knav_qmss_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index b73e353..eacad57 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
range->num_irqs++;
- if (oirq.args_count == 3)
+ if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
range->irqs[i].cpu_map =
(oirq.args[2] & 0x0000ff00) >> 8;
}
--
2.10.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] soc: ti: qmss: fix the case when !SMP
2016-11-30 16:53 [PATCH v2] soc: ti: qmss: fix the case when !SMP Grygorii Strashko
@ 2016-11-30 17:09 ` Grygorii Strashko
2016-11-30 17:13 ` Santosh Shilimkar
0 siblings, 1 reply; 4+ messages in thread
From: Grygorii Strashko @ 2016-11-30 17:09 UTC (permalink / raw)
To: linux-arm-kernel
+ Santosh Shilimkar <santosh.shilimkar@oracle.com>
On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
> The irq_set_affinity_hint() will always fail when !SMP and
> Networking will fail on Keystone 2 devices in this case.
> Hence, fix by ignoring IRQ affinity settings when !SMP.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/soc/ti/knav_qmss_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b73e353..eacad57 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
>
> range->num_irqs++;
>
> - if (oirq.args_count == 3)
> + if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
> range->irqs[i].cpu_map =
> (oirq.args[2] & 0x0000ff00) >> 8;
> }
>
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] soc: ti: qmss: fix the case when !SMP
2016-11-30 17:09 ` Grygorii Strashko
@ 2016-11-30 17:13 ` Santosh Shilimkar
2016-11-30 21:11 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Santosh Shilimkar @ 2016-11-30 17:13 UTC (permalink / raw)
To: linux-arm-kernel
Hi Anrd,
Can you apply this to your non critical fixes queue ?
On 11/30/2016 9:09 AM, Grygorii Strashko wrote:
> + Santosh Shilimkar <santosh.shilimkar@oracle.com>
>
> On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
>> The irq_set_affinity_hint() will always fail when !SMP and
>> Networking will fail on Keystone 2 devices in this case.
>> Hence, fix by ignoring IRQ affinity settings when !SMP.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
>> drivers/soc/ti/knav_qmss_queue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>> b/drivers/soc/ti/knav_qmss_queue.c
>> index b73e353..eacad57 100644
>> --- a/drivers/soc/ti/knav_qmss_queue.c
>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct
>> knav_device *kdev,
>>
>> range->num_irqs++;
>>
>> - if (oirq.args_count == 3)
>> + if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
>> range->irqs[i].cpu_map =
>> (oirq.args[2] & 0x0000ff00) >> 8;
>> }
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] soc: ti: qmss: fix the case when !SMP
2016-11-30 17:13 ` Santosh Shilimkar
@ 2016-11-30 21:11 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-11-30 21:11 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday, November 30, 2016 9:13:44 AM CET Santosh Shilimkar wrote:
>
> Can you apply this to your non critical fixes queue ?
>
> On 11/30/2016 9:09 AM, Grygorii Strashko wrote:
> > + Santosh Shilimkar <santosh.shilimkar@oracle.com>
> >
> > On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
> >> The irq_set_affinity_hint() will always fail when !SMP and
> >> Networking will fail on Keystone 2 devices in this case.
> >> Hence, fix by ignoring IRQ affinity settings when !SMP.
> >>
> >> Cc: Arnd Bergmann <arnd@arndb.de>
> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> >> ---
> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
>
>
Applied, thanks!
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-30 21:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 16:53 [PATCH v2] soc: ti: qmss: fix the case when !SMP Grygorii Strashko
2016-11-30 17:09 ` Grygorii Strashko
2016-11-30 17:13 ` Santosh Shilimkar
2016-11-30 21:11 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox