From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: davinci: request cs_gpio's from probe
Date: Mon, 15 Sep 2014 16:06:42 +0300 [thread overview]
Message-ID: <5416E462.7010406@ti.com> (raw)
In-Reply-To: <20140913162858.GG7960@sirena.org.uk>
On 09/13/2014 07:28 PM, Mark Brown wrote:
> On Fri, Sep 12, 2014 at 05:54:00PM +0300, Grygorii Strashko wrote:
>
>> static void davinci_spi_cleanup(struct spi_device *spi)
>> {
>> - if (spi->cs_gpio >= 0)
>> - gpio_free(spi->cs_gpio);
>> }
>
> This function is now empty so should be removed. I've applied for now
> but please send a followup fixing this.
>
The function davinci_spi_cleanup() will be reused by following patch
"[PATCH v3] spi: davinci: add support for adding delay between word's transmissions"
http://www.spinics.net/lists/devicetree/msg49141.html
So, in broonie/spi.git/for-next it will not be empty.
Again, I've missed description of this dependency, sorry for that.
Regards,
-grygorii
next prev parent reply other threads:[~2014-09-15 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 14:54 [PATCH] spi: davinci: request cs_gpio's from probe Grygorii Strashko
2014-09-13 16:28 ` Mark Brown
2014-09-15 13:06 ` Grygorii Strashko [this message]
2014-09-15 16:38 ` Mark Brown
2014-09-16 11:14 ` [PATCH] spi: davinci: remove empty function davinci_spi_cleanup Grygorii Strashko
2014-09-16 17:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416E462.7010406@ti.com \
--to=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).