From: k.kozlowski@samsung.com (Krzysztof Kozłowski)
To: linux-arm-kernel@lists.infradead.org
Subject: Exynos build failure in -next allmodconfig
Date: Tue, 16 Sep 2014 13:44:44 +0200 [thread overview]
Message-ID: <541822AC.8040805@samsung.com> (raw)
In-Reply-To: <20140915175709.GE12361@n2100.arm.linux.org.uk>
On 15.09.2014 19:57, Russell King - ARM Linux wrote:
> On Mon, Sep 15, 2014 at 09:34:58AM -0700, Mark Brown wrote:
>> On Mon, Sep 15, 2014 at 11:57:09AM +0100, Build bot for Mark Brown wrote:
>>
>> Today's -next got a build failure in ARM allmodconfig due to platsmp.c:
>>
>> | arch/arm/mach-exynos/platsmp.c:198:31: warning: incorrect type in return expression (different address spaces)
>> | arch/arm/mach-exynos/platsmp.c:198:31: expected void [noderef] <asn:2>*
>> | arch/arm/mach-exynos/platsmp.c:198:31: got void *
>> | arch/arm/mach-exynos/platsmp.c:198:31: warning: incorrect type in return expression (different address spaces)
>> | arch/arm/mach-exynos/platsmp.c:198:31: expected void [noderef] <asn:2>*
>> | arch/arm/mach-exynos/platsmp.c:198:31: got void *
>> | CC arch/arm/mach-exynos/platsmp.o
>> | /tmp/ccC9fkwF.s: Assembler messages:
>> | /tmp/ccC9fkwF.s:423: Error: selected processor does not support ARM mode `isb '
>> | /tmp/ccC9fkwF.s:428: Error: selected processor does not support ARM mode `isb '
>> | /tmp/ccC9fkwF.s:429: Error: selected processor does not support ARM mode `dsb '
>> | scripts/Makefile.build:257: recipe for target 'arch/arm/mach-exynos/platsmp.o' failed
>>
>> Looks like we need a compiler flags override for that file.
>
> Or.. the question is why a .c file is not using the proper macros.
Actually I am the one to blame for build failure (commit: "ARM: EXYNOS:
Move code from hotplug.c to platsmp.c"). The problem is
v7_exit_coherency_flush() which I think does not make sense on ARMv6.
I'll replace the ISB and DSB commands with macros but the real question
is whether the mach-exynos/platsmp.c file and mach-exynos directory
should be compiled when CONFIG_ARCH_EXYNOS is not defined?
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-09-16 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XTTy1-0000vT-NC@cassiel.sirena.org.uk>
[not found] ` <20140915163458.GS7960@sirena.org.uk>
2014-09-15 17:57 ` Exynos build failure in -next allmodconfig Russell King - ARM Linux
2014-09-16 11:44 ` Krzysztof Kozłowski [this message]
2014-09-16 11:56 ` Russell King - ARM Linux
2014-09-16 12:01 ` Tomasz Figa
2014-09-16 15:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541822AC.8040805@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).