From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] mfd: syscon: Decouple syscon interface from platform devices
Date: Fri, 19 Sep 2014 19:39:54 +0200 [thread overview]
Message-ID: <541C6A6A.40006@gmail.com> (raw)
In-Reply-To: <541C47BD.3070601@gmail.com>
On 19.09.2014 17:11, Tomasz Figa wrote:
>> +
>> + if (!of_device_is_available(np) ||
>
> Wouldn't it be enough to simply call of_find_device_by_node(np) and if
> it fails then instead create a dummy device?
>
>> + of_node_test_and_set_flag(np, OF_POPULATED)) {
One more thing I forgot to mention, the call to
of_node_test_and_set_flag() is also wrong, because it sets the flag,
marking the device as already populated, while it isn't.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-09-19 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:06 [PATCH v4] mfd: syscon: Decouple syscon interface from platform devices Pankaj Dubey
2014-09-19 14:18 ` Javier Martinez Canillas
2014-09-19 15:11 ` Tomasz Figa
2014-09-19 17:39 ` Tomasz Figa [this message]
2014-09-22 4:11 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C6A6A.40006@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).