From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] bus: brcmstb_gisb: register the fault code hook
Date: Fri, 19 Sep 2014 12:45:45 -0700 [thread overview]
Message-ID: <541C87E9.1080600@gmail.com> (raw)
In-Reply-To: <1411155880-23447-2-git-send-email-f.fainelli@gmail.com>
On 09/19/2014 12:44 PM, Florian Fainelli wrote:
> Commit 44127b771d9c31 ("bus: add Broadcom GISB bus arbiter timeout/error
> handler") added everything that is required to register an ARM fault
> handler for imprecise external aborts, except that there is nothing
> calling this currently.
>
> We do not need to export that specific function and have to update
> arch/arm/mach-bcm/brcmstb.c to call it, simply, register the fault
> handler with an arch_initcall.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/bus/brcmstb_gisb.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/brcmstb_gisb.c b/drivers/bus/brcmstb_gisb.c
> index f2cd6a2d40b4..daae4f77f34a 100644
> --- a/drivers/bus/brcmstb_gisb.c
> +++ b/drivers/bus/brcmstb_gisb.c
> @@ -48,6 +48,7 @@ struct brcmstb_gisb_arb_device {
> struct list_head next;
> u32 valid_mask;
> const char *master_names[sizeof(u32) * BITS_PER_BYTE];
> + u32 saved_timeout;
Meh, this change is unrelated, I will resubmit a v2 shortly, sorry for
the noise.
> };
>
> static LIST_HEAD(brcmstb_gisb_arb_device_list);
> @@ -160,11 +161,13 @@ static int brcmstb_bus_error_handler(unsigned long addr, unsigned int fsr,
> return ret;
> }
>
> -void __init brcmstb_hook_fault_code(void)
> +static int __init brcmstb_hook_fault_code(void)
> {
> hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0,
> "imprecise external abort");
> + return 0;
> }
> +arch_initcall(brcmstb_hook_fault_code)
>
> static irqreturn_t brcmstb_gisb_timeout_handler(int irq, void *dev_id)
> {
>
next prev parent reply other threads:[~2014-09-19 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 19:44 [PATCH 0/2] bus: brcmstb_gisb: misc fixes Florian Fainelli
2014-09-19 19:44 ` [PATCH 1/2] bus: brcmstb_gisb: register the fault code hook Florian Fainelli
2014-09-19 19:45 ` Florian Fainelli [this message]
2014-09-20 13:19 ` Thomas Petazzoni
2014-09-21 23:10 ` Brian Norris
2014-09-22 6:57 ` Thomas Petazzoni
2014-09-19 19:44 ` [PATCH 2/2] bus: brcmstb_gisb: save and restore GISB timeout Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C87E9.1080600@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).