linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] ARM: meson: add watchdog driver
Date: Sat, 20 Sep 2014 08:30:28 -0700	[thread overview]
Message-ID: <541D9D94.2010400@roeck-us.net> (raw)
In-Reply-To: <1411158989-8075-3-git-send-email-carlo@caione.org>

On 09/19/2014 01:36 PM, Carlo Caione wrote:
> This patch adds the watchdog driver for the Amlogic Meson SoCs used also
> to reboot the device.
>
> Signed-off-by: Carlo Caione <carlo@caione.org>
> ---
[ ... ]
> +module_param(nowayout, bool, 0);
> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
> +		"(default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> +

Checkpatch says:

WARNING: quoted string split across lines
#295: FILE: drivers/watchdog/meson_wdt.c:231:
+MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "
+		"(default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");

Please fix.

Thanks,
Guenter

  reply	other threads:[~2014-09-20 15:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19 20:36 [PATCH v3 0/4] ARM: meson: watchdog driver Carlo Caione
2014-09-19 20:36 ` [PATCH v3 1/4] ARM: docs: add documentation binding for meson watchdog Carlo Caione
2014-09-20 15:28   ` Guenter Roeck
2014-09-20 16:08     ` Carlo Caione
2014-09-20 16:10       ` Guenter Roeck
2014-09-19 20:36 ` [PATCH v3 2/4] ARM: meson: add watchdog driver Carlo Caione
2014-09-20 15:30   ` Guenter Roeck [this message]
2014-09-20 16:15     ` Carlo Caione
2014-09-20 16:29       ` Guenter Roeck
2014-09-19 20:36 ` [PATCH v3 3/4] ARM: DTS: meson: update DTSI to add watchdog node Carlo Caione
2014-09-19 20:36 ` [PATCH v3 4/4] ARM: defconfig: update multi_v7_defconfig Carlo Caione
2014-09-20  2:50 ` [PATCH v3 0/4] ARM: meson: watchdog driver Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541D9D94.2010400@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).