linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings
Date: Tue, 23 Sep 2014 14:06:21 +0200	[thread overview]
Message-ID: <5421623D.6090609@atmel.com> (raw)
In-Reply-To: <1411472564-32448-1-git-send-email-andreas.henriksson@endian.se>

On 23/09/2014 13:42, Andreas Henriksson :
> As discovered on a custom board similar to at91sam9263ek and basing
> its devicetree on that one apparently the pin muxing doesn't get
> set up properly. This was discovered since the custom boards u-boot
> does funky stuff with the pin muxing and leaved it set to SPI
> which made the MMC driver not work under Linux.
> The fix is simply to define the given configuration as the default.
> This probably worked by pure luck before, but it's better to
> make the muxing explicitly set.
> 
> CC: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Signed-off-by: Andreas Henriksson <andreas.henriksson@endian.se>

Thanks a lot for having fix this Andreas.

> ---
>  arch/arm/boot/dts/at91sam9263ek.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/at91sam9263ek.dts b/arch/arm/boot/dts/at91sam9263ek.dts
> index 5cf93ee..33a4f9a 100644
> --- a/arch/arm/boot/dts/at91sam9263ek.dts
> +++ b/arch/arm/boot/dts/at91sam9263ek.dts
> @@ -64,6 +64,7 @@
>  			};
>  
>  			mmc0: mmc at fff80000 {
> +				pinctrl-names = "default";

On AT91, we tend to have this property directly in the SoC .dtsi file:
can you please add this "default" name to the 2 mmc hosts in
at91sam9263.dtsi file?

Thanks, best regards.

>  				pinctrl-0 = <
>  					&pinctrl_board_mmc0
>  					&pinctrl_mmc0_clk
> 


-- 
Nicolas Ferre

  parent reply	other threads:[~2014-09-23 12:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 11:42 [PATCH] ARM: at91: fix at91sam9263ek DT mmc pinmuxing settings Andreas Henriksson
2014-09-23 11:47 ` Boris BREZILLON
2014-09-23 12:06 ` Nicolas Ferre [this message]
2014-09-23 15:12   ` [PATCH v2] " Andreas Henriksson
2014-09-23 15:43     ` Boris BREZILLON
2014-09-24 16:11     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5421623D.6090609@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).