* FIX Me in pgtable.h
@ 2014-09-23 13:04 nick
2014-09-23 13:46 ` Krzysztof Kozłowski
2014-09-24 3:21 ` Laura Abbott
0 siblings, 2 replies; 6+ messages in thread
From: nick @ 2014-09-23 13:04 UTC (permalink / raw)
To: linux-arm-kernel
Greetings Arm Maintainers,
I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
and should be changed.
Thanks,
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX Me in pgtable.h
2014-09-23 13:04 FIX Me in pgtable.h nick
@ 2014-09-23 13:46 ` Krzysztof Kozłowski
2014-09-23 15:30 ` Nicholas Krause
2014-09-24 3:21 ` Laura Abbott
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozłowski @ 2014-09-23 13:46 UTC (permalink / raw)
To: linux-arm-kernel
On 23.09.2014 15:04, nick wrote:
> Greetings Arm Maintainers,
> I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
> value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
> and should be changed.
Dear Nick Krause,
Before you start coding - do you have necessary ARM-based hardware to
test your changes?
Changing email won't remove LKML archives...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX Me in pgtable.h
2014-09-23 13:46 ` Krzysztof Kozłowski
@ 2014-09-23 15:30 ` Nicholas Krause
0 siblings, 0 replies; 6+ messages in thread
From: Nicholas Krause @ 2014-09-23 15:30 UTC (permalink / raw)
To: linux-arm-kernel
I don't have any hardware to test this over, however I can emulate a
arm system over qemu if needed.
I was just trying to help out if we need hardware I can't test and
again I am sorry for the terrible patches.
It was never my goal to be a nuisance.
Nick
On Tue, Sep 23, 2014 at 9:46 AM, Krzysztof Koz?owski
<k.kozlowski@samsung.com> wrote:
> On 23.09.2014 15:04, nick wrote:
>>
>> Greetings Arm Maintainers,
>> I am wondering about the fix me in pgtable.h for define kern_addr_valid
>> and how to set it to a correct
>> value as you state that this needs to be fixed as the defined macro is
>> still 1. This is probably incorrect
>> and should be changed.
>
>
> Dear Nick Krause,
>
> Before you start coding - do you have necessary ARM-based hardware to test
> your changes?
>
> Changing email won't remove LKML archives...
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX Me in pgtable.h
2014-09-23 13:04 FIX Me in pgtable.h nick
2014-09-23 13:46 ` Krzysztof Kozłowski
@ 2014-09-24 3:21 ` Laura Abbott
2014-09-24 11:38 ` nick
1 sibling, 1 reply; 6+ messages in thread
From: Laura Abbott @ 2014-09-24 3:21 UTC (permalink / raw)
To: linux-arm-kernel
On 9/23/2014 6:04 AM, nick wrote:
> Greetings Arm Maintainers,
> I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
> value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
> and should be changed.
> Thanks,
> Nick
>
It's not clear to me how valuable fixing kern_addr_valid would actually
be for arm. It seems to be used in exactly one place, fs/proc/kcore.c
and the associated Kconfig is explicitly marked if !ARM. Nearly all
other archs minus x86, arm64 and sparc are in the same boat as well.
Thanks,
Laura
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX Me in pgtable.h
2014-09-24 3:21 ` Laura Abbott
@ 2014-09-24 11:38 ` nick
0 siblings, 0 replies; 6+ messages in thread
From: nick @ 2014-09-24 11:38 UTC (permalink / raw)
To: linux-arm-kernel
On 14-09-23 11:21 PM, Laura Abbott wrote:
> On 9/23/2014 6:04 AM, nick wrote:
>> Greetings Arm Maintainers,
>> I am wondering about the fix me in pgtable.h for define kern_addr_valid and how to set it to a correct
>> value as you state that this needs to be fixed as the defined macro is still 1. This is probably incorrect
>> and should be changed.
>> Thanks,
>> Nick
>>
>
> It's not clear to me how valuable fixing kern_addr_valid would actually
> be for arm. It seems to be used in exactly one place, fs/proc/kcore.c
> and the associated Kconfig is explicitly marked if !ARM. Nearly all
> other archs minus x86, arm64 and sparc are in the same boat as well.
>
> Thanks,
> Laura
>
Laura,
Can we remove it then as it seems that it's not needed at all.
Cheers Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* FIX ME in pgtable.h
@ 2014-07-12 5:41 Nick Krause
0 siblings, 0 replies; 6+ messages in thread
From: Nick Krause @ 2014-07-12 5:41 UTC (permalink / raw)
To: linux-arm-kernel
There is a fix me message I am hitting with cscope on line 317 of this
file about #define kern_addr_valid(addr) (1) not being correct.
I am wondering what value this should be set to. Thanks for the advice
so I can remove this fix me from the kernel.
Cheers Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-24 11:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23 13:04 FIX Me in pgtable.h nick
2014-09-23 13:46 ` Krzysztof Kozłowski
2014-09-23 15:30 ` Nicholas Krause
2014-09-24 3:21 ` Laura Abbott
2014-09-24 11:38 ` nick
-- strict thread matches above, loose matches on Subject: below --
2014-07-12 5:41 FIX ME " Nick Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).