From mboxrd@z Thu Jan 1 00:00:00 1970 From: maitysanchayan@gmail.com (Sanchayan Maity) Date: Fri, 26 Sep 2014 15:14:51 +0530 Subject: [PATCH v2] ARM: dts: vf610-colibri: Add ADC support In-Reply-To: <20140926020745.GH21077@dragon> References: <20140926020745.GH21077@dragon> Message-ID: <54253593.2060508@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 26 September 2014 07:37 AM, Shawn Guo wrote: > On Fri, Sep 19, 2014 at 04:56:13PM +0530, Sanchayan Maity wrote: >> Enable ADC support for Colibri VF61 modules >> >> Signed-off-by: Sanchayan Maity >> --- >> arch/arm/boot/dts/vf610-colibri.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi >> index 0cd8343..6fd099e 100644 >> --- a/arch/arm/boot/dts/vf610-colibri.dtsi >> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi >> @@ -27,6 +27,16 @@ >> >> }; >> >> +&adc0 { >> + pinctrl-names = "default"; > > Sorry for missing it, but I would expect properties pinctrl-names and > pinctrl-0 appear as a couple. Should we drop property pinctrl-names > here? > > Shawn We can actually drop this here. Vybrid has dedicated pads for 4 ADC channels. Since we are using only these dedicated ADC channels, no pin multiplexing is required. So we can drop the pinctrl-names property. Will clean and send out a v3 patch. Thanks for pointing this out. - Sanchayan > >> + status = "okay"; >> +}; >> + >> +&adc1 { >> + pinctrl-names = "default"; >> + status = "okay"; >> +}; >> + >> &esdhc1 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_esdhc1>; >> -- >> 1.7.9.5 >>