From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 753A4C3ABB0 for ; Mon, 5 May 2025 11:33:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aB3cMr3JDp0nKZr8OwsHEx3We5XLotlduuz1352Eao4=; b=sK2n7jRcF+p/wIrqblo0nh8wJW W2znmIlPhL1zMM1hadcHokWnX8k1/CIUHtO0fclHDvMmYRQUxONFQn/vsJjrXf7fwJBNwf9xGmv/T pyE/kBR46H1FYGXI2On8n73IploOP+4ktxj/pT2xdzECBz0By2bCYTxQkjmuZU3GaO6EaQ3chNcaw DVZtlw3uXTf1+YUzJpq/9TJsMBlYvFHcU1KdVMuKn+4cJtNFOam+YfMoHqSnaQK395BDlxdzKeUL6 vgSJoHfYUYAfaZbsgTlX6Ez+VKRUS/rLooAR3HmVFrlCaki9Rb8BlDZkuT4BZPtj9oaBweFizK5Q8 rxwxUBUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uBu48-00000007AsS-0k7E; Mon, 05 May 2025 11:32:56 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uBtzq-00000007AGC-2jGD for linux-arm-kernel@lists.infradead.org; Mon, 05 May 2025 11:28:31 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-ac2bdea5a38so586359966b.0 for ; Mon, 05 May 2025 04:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1746444509; x=1747049309; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aB3cMr3JDp0nKZr8OwsHEx3We5XLotlduuz1352Eao4=; b=O6RNRD2k32SteQwuwlzFco9OdU66OAO8JmdnuYVhU6WIXivv43Ns2s3YkTrfLB1rYA XaClK22SgAAJf7igH86nNfSTlSyp15Wc11ci10UtHyVYc0gRxu94qVna3283eyl+af7w UubPMMPF6y+P/Lyx0fLivmvIQdXqB4mRR2VQmsBgVVF8a6cL+cfMeYygCBVaP+oU17Ww Lk8NAH42+7ul61qeC7ZWDBI9RBoGYvY8KniEc+APsW8rTnJ9nMBWoyCUQ2Vsz4NqMeeZ jjDqtF9Tsx2DunhEUZzlrSzahLmDI8t2IZiuV3dJHpF8cZY72fy3nCz7hkCiptuD9vvI vZRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746444509; x=1747049309; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aB3cMr3JDp0nKZr8OwsHEx3We5XLotlduuz1352Eao4=; b=s0Wb4fKA6MfSsQgfcsAsJeXL3kZ3avQjQo0wfbuPhqQyglLHp88+Y660t46JaNNMeZ hX0Nx0OZfMldc2fRuDYIaHwd5ykhC3/LubfrqyFE3pqQRSisodIPm2Bsk41P5Hu9eRqe sDHea53zkC1kLUQrOhR3oJjNiJU+gnPpnC7WkIDao0Mlhg6lwqXVlXB3NBsESdsV7zo9 e0+MTCs4dLdQc2FaCKpAUcAgTkpHj0yYptgMrQwYk6XrAwvu2oLKTF72bXeHqFYyawl/ PrmPiFPmwsy2nYHImzjwk2eGZMOOwgh/ZTXx04ALwSiF9EHiwpOvEwD8wBJ0Tzt0mqGE u8yw== X-Forwarded-Encrypted: i=1; AJvYcCXzbZgYZuUaGXScOn6rOFU0yI1agaddLEAiu6dkWanWVuV09SK9UppsYC5YKcaRLX63af5MePbkgJTKTDWOu2Ex@lists.infradead.org X-Gm-Message-State: AOJu0YwGhggTioEjBmieAYIGugHspX3CqOjbkycqmJGp40LPh/NA7CvG zux5CbRjWamDJttPVs7uZ7eIHzdMCaf/Nck9LI+Oa2ECb6rDUb66ZYvOURIrIOY= X-Gm-Gg: ASbGncv3bpDQRYRTYSTfNR2dnhhm5nBsmYVmO/g1utIkAJPeDdmL0LSyuLRh26DDWAe qz+AdRyjgJTgVfCpCgaF1D7xpwV0lxsN/Mquu1La50DGsWDxpMEWfYDCeOX7rCpvv+NFJJmieuC 4DoxkleAgkKBwMb9i2vkpX+C1F1eaaSenklzV/+cDXSD0yWAW8h7LSJemQ4iCRj7qjwkkW4tGCu EOZvaAZmwGH5I6+doNwvcrMgPh03FdAYgN35CR1C8dvMJTUWdk+Cryq8cct49/5L2IkYqDceCpU ODAVMsYTrJwKsAVewPHysEtogKhF9U+I9YHphmyfLtQKjGOjQVw+c0xokhek X-Google-Smtp-Source: AGHT+IGvEp3fdacUme4FWMSlQbtpUEv8ay4IyBgw8S68wSBoAmf9cWSX9tpMSyCX12ZWHunmUEvARQ== X-Received: by 2002:a17:907:3e09:b0:ace:c43a:63e9 with SMTP id a640c23a62f3a-ad1a4a8d7dfmr571983666b.42.1746444508643; Mon, 05 May 2025 04:28:28 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.166]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad18914733esm476716866b.33.2025.05.05.04.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 04:28:28 -0700 (PDT) Message-ID: <542674b6-bdcf-4149-99b4-a5568745eabd@tuxon.dev> Date: Mon, 5 May 2025 14:28:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] dt-bindings: PCI: renesas,r9a08g045s33-pcie: Add documentation for the PCIe IP on Renesas RZ/G3S To: Bjorn Helgaas Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, saravanak@google.com, p.zabel@pengutronix.de, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Claudiu Beznea References: <20250501201636.GA776341@bhelgaas> From: Claudiu Beznea Content-Language: en-US In-Reply-To: <20250501201636.GA776341@bhelgaas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250505_042830_701224_A6D4EB31 X-CRM114-Status: GOOD ( 17.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bjorn, On 01.05.2025 23:16, Bjorn Helgaas wrote: > On Wed, Apr 30, 2025 at 01:32:32PM +0300, Claudiu wrote: >> From: Claudiu Beznea >> >> The PCIe IP available on the Renesas RZ/G3S complies with the PCI Express >> Base Specification 4.0. It is designed for root complex applications and >> features a single-lane (x1) implementation. Add documentation for it. >> The interrupts, interrupt-names, resets, reset-names, clocks, clock-names >> description were obtained from the hardware manual. > >> + pcie@11e40000 { >> + compatible = "renesas,r9a08g045s33-pcie"; >> + reg = <0 0x11e40000 0 0x10000>; >> + ranges = <0x03000000 0 0x30000000 0 0x30000000 0 0x8000000>; >> + dma-ranges = <0x42000000 0 0x48000000 0 0x48000000 0 0x8000000>; >> + bus-range = <0x0 0xff>; >> + clocks = <&cpg CPG_MOD R9A08G045_PCI_ACLK>, >> + <&cpg CPG_MOD R9A08G045_PCI_CLKL1PM>; >> + clock-names = "aclk", "clkl1pm"; >> + resets = <&cpg R9A08G045_PCI_ARESETN>, >> + <&cpg R9A08G045_PCI_RST_B>, >> + <&cpg R9A08G045_PCI_RST_GP_B>, >> + <&cpg R9A08G045_PCI_RST_PS_B>, >> + <&cpg R9A08G045_PCI_RST_RSM_B>, >> + <&cpg R9A08G045_PCI_RST_CFG_B>, >> + <&cpg R9A08G045_PCI_RST_LOAD_B>; >> + reset-names = "aresetn", "rst_b", "rst_gp_b", "rst_ps_b", >> + "rst_rsm_b", "rst_cfg_b", "rst_load_b"; > > Could this be structured in a way that separates the shared Root > Complex properties from the ones that are specific to the Root Port? > I know the current hardware only supports a single Root Port, but I > think we should plan to be able to support multiple Root Ports. I'm not sure how should I do this. These are just the reset signals as the manual describes them. Can you, please, point me an example driver/device tree that I could check? Thank you for your review, Claudiu > >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + interrupt-names = "int_serr", "int_serr_cor", "int_serr_nonfatal", >> + "int_serr_fatal", "axi_err_int", "inta_rc", >> + "intb_rc", "intc_rc", "intd_rc", >> + "intmsi_rc", "int_link_bandwidth", "int_pm_pme", >> + "dma_int", "pcie_evt_int", "msg_int", >> + "int_all"; >> + #interrupt-cells = <1>; >> + interrupt-map-mask = <0 0 0 7>; >> + interrupt-map = <0 0 0 1 &pcie_intx 0>, /* INT A */ >> + <0 0 0 2 &pcie_intx 1>, /* INT B */ >> + <0 0 0 3 &pcie_intx 2>, /* INT C */ >> + <0 0 0 4 &pcie_intx 3>; /* INT D */ >> + device_type = "pci"; >> + num-lanes = <1>; >> + #address-cells = <3>; >> + #size-cells = <2>; >> + power-domains = <&cpg>; >> + renesas,sysc = <&sysc>; >> + vendor-id = <0x1912>; >> + device-id = <0x0033>; >> + >> + pcie_intx: legacy-interrupt-controller { >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + #address-cells = <0>; >> + interrupt-parent = <&gic>; >> + interrupts = , >> + , >> + , >> + ; >> + }; >> + }; >> + }; >> + >> +... >> -- >> 2.43.0 >>