public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: daniel@zonque.org (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: pxa-dt and multiple platforms support
Date: Sat, 27 Sep 2014 20:08:51 +0200	[thread overview]
Message-ID: <5426FD33.8080404@zonque.org> (raw)
In-Reply-To: <877g0pc5g6.fsf@free.fr>

Hi Robert,

On 09/27/2014 07:56 PM, Robert Jarzmik wrote:
> When you added support for device-tree for pxa3xx, in commit "ARM: pxa3xx: add
> generic DT machine code" (e7749a2) you wrote : "This file can be extended to
> also support pxa2xx".
> 
> I was wondering is that is really possible with the current pxa status, because
> :
>  - you have to include mach/pxa3xx.h
>    => this includes mach/pxa3xx-regs.h
>    => this is specific to pxa3xx architecture
> 
> If I add pxa27x support into the same file, I'll have to include mach/pxa27x.h
> (because the initialization functions are there, same reason as yours for
> mach/pxa3xx-regs.h).
>    => this includes mach/pxa2xx-regs.h
>    => this is specific to pxa2xx architecture
> 
> Of course there will be a lot of defines conflicts, as both platforms share the
> same register names ...
> 
> So did you have something specific in mind, or should I rename pxa-dt.c into
> pxa3xx-dt.c, and create pxa27-dt.c (this last option is my current choice unless
> a better ideas emerges) ?

I think the latter is fine for now. I certainly didn't work on pxa27x DT
bits yet.


Thanks,
Daniel

  reply	other threads:[~2014-09-27 18:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 17:56 pxa-dt and multiple platforms support Robert Jarzmik
2014-09-27 18:08 ` Daniel Mack [this message]
2014-09-27 19:29   ` Arnd Bergmann
2014-09-27 19:43     ` Robert Jarzmik
2014-09-27 19:56       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5426FD33.8080404@zonque.org \
    --to=daniel@zonque.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox