From: yocto6@gmail.com (nick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume
Date: Sun, 28 Sep 2014 16:45:37 -0400 [thread overview]
Message-ID: <54287371.50404@gmail.com> (raw)
In-Reply-To: <20140928162357.GA2542@sudip-PC>
On 14-09-28 12:23 PM, Sudip Mukherjee wrote:
> On Sat, Sep 27, 2014 at 10:50:52PM -0400, Nicholas Krause wrote:
>> This removes the FIXME message and issue with reading in this driver before resuming
>> in the function, sa1111_resume.
>>
>> Signed-off-by: Nicholas Krause <yocto6@gmail.com>
>> ---
>> arch/arm/common/sa1111.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
>> index e57d7e5..0c4b9a9 100644
>> --- a/arch/arm/common/sa1111.c
>> +++ b/arch/arm/common/sa1111.c
>> @@ -950,9 +950,7 @@ static int sa1111_resume(struct platform_device *dev)
>>
>> /*
>> * Ensure that the SA1111 is still here.
>> - * FIXME: shouldn't do this here.
>> */
>> - id = sa1111_readl(sachip->base + SA1111_SKID);
>
> do you understand the effect of removing this???
> what is the value of id in the next part of the code?
>
> thanks
> sudip
>> if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
>> __sa1111_remove(sachip);
>> platform_set_drvdata(dev, NULL);
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
We will set the driver data to NULL and therefore may cause a bug due to NULL data.
Nick
prev parent reply other threads:[~2014-09-28 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 2:50 [PATCH] arm: Remove read of issue in sa1111.c in sa1111_resume Nicholas Krause
2014-09-28 3:31 ` Randy Dunlap
2014-09-28 4:07 ` nick
2014-09-28 16:23 ` Sudip Mukherjee
2014-09-28 20:45 ` nick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54287371.50404@gmail.com \
--to=yocto6@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).