From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31A67C54E71 for ; Fri, 22 Mar 2024 15:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KFRcLbfVY52pbKp+d9cDMY+1Xd0x/IFLDk4LgIWziik=; b=ldHuf6dtLQkzsv hPSvj/Xk6iCfsv7UpeLx98XOW7VxxYv2wa2f4yickHRwrSnK5gHZo0foEi7J5EEyah9Zn1CQ85aqp Ak9oETeANjIgWC5DMl1WGH5f368ntBp7KaNUvH7NGhl5EGLff/zCoGTItQ2K5VDVMmASW+k+nXMM/ lU5R7KtqpfcYaTfNUYKMhE6k7nG6dmiv1+1d5lNfweTYW310SEe+Q+NaHcn3o5vHnrwRZq5EXvFPF 8VOrsrSZkAen1deeUvnmvUj+bCDOaiXHBC3eluTt0yfJAo9WCs9T4HBL8xHKe8JKJQZmsRqViQHjm ED55gV7J9sDYrJwSjt3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnhI6-00000007qhS-3Kjh; Fri, 22 Mar 2024 15:58:46 +0000 Received: from mail-db8eur05on20714.outbound.protection.outlook.com ([2a01:111:f400:7e1a::714] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnhI4-00000007qfw-0Iwt for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 15:58:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kiFHgpffwVKpnqmNTLT3zNNooG4+P1QHYTRxe8Jf+H+IwhH9cG9BglxOcq6FgQgVpkjlwGBHRvkyXMCB1J1XhSAEfEecNPaOk8V8P+0ygwqd7JikxZLfAnXjmk63x+h2AnOQxHvubap4SFFlXGvljy5ijVV+IRweJJbpX9B3RSM00mM5/7tB3xK63ZcN17vmd/dXoD8qKJQ11qQ0XPLvUQyyFH6pD/4B3Jb1xcJh99H3SJTujEFfBQGNXoftpgNfjMJ0Yv41wtndhsZp6zNthQEUGJBgOGI/5wiv5Wvtby9IZuiXsxT4cNm8goD1yY/tPmtQCW+IwsNn5OpLDvC5Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2xuFEA7Yulko8Or7jy7HwUz7TI569ysIaCRUwAskxyY=; b=NMrDAfniFThFB9IsHZ1soBUF1OzmdcdR0kcCBnayFOUBFiDDmrPv5Z7UBVNbHAzWYvj8IOWNIxA6avkwnGj0EIlNdSnrFUVXSAGYJaT0tUFw7eOI5CuPolauQ0uUa3vssJhia8PUyVJCmjsT0/tGelyXJaZilXaapchlKM910dt3eRlq3od6erCaTfJIS9T4nE1SGNw7tiXtP1kPpYNUX70B/FGeCCkJPfpMoATga5hk9vfRmmBx34Em6JsmM1B7/A3PCzYYmhiFYaxN/OQm1TBFPctJwkY1/5mfb1dW2WQmX0Z+O/TMHsd2KE7dJtQVuKiBU3z63+QHHFP5TtXQRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=solid-run.com; dmarc=pass action=none header.from=solid-run.com; dkim=pass header.d=solid-run.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidrn.onmicrosoft.com; s=selector1-solidrn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2xuFEA7Yulko8Or7jy7HwUz7TI569ysIaCRUwAskxyY=; b=L0TsjYBR0ehUuXY01xY5TMD05URZjALGI2jUxz4rgUOIYiMMYaPcfDP3WyECgaKaAfYsJ3tnZnWIcisI/zVVP2Zas5TQX4Fk35coVv/RzuwO3yx0QMKetBOMQBIxi2RWOJNdEBNqQ2/zOmkaCF1W4LHhsTjTg0efZO4Zv4mUEvc= Received: from AM9PR04MB7586.eurprd04.prod.outlook.com (2603:10a6:20b:2d5::17) by AM9PR04MB9002.eurprd04.prod.outlook.com (2603:10a6:20b:409::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 15:58:37 +0000 Received: from AM9PR04MB7586.eurprd04.prod.outlook.com ([fe80::57e1:e1cb:74e2:2e9d]) by AM9PR04MB7586.eurprd04.prod.outlook.com ([fe80::57e1:e1cb:74e2:2e9d%5]) with mapi id 15.20.7409.023; Fri, 22 Mar 2024 15:58:37 +0000 From: Josua Mayer To: Andrew Lunn CC: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yazan Shhady , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] arm64: dts: add description for solidrun cn9130 som and clearfog boards Thread-Topic: [PATCH 2/2] arm64: dts: add description for solidrun cn9130 som and clearfog boards Thread-Index: AQHae9lamF1Na8/mpEGgdJkfFpR9o7FCvoaAgADHmICAADb7AIAAKS8AgAAC+YCAAAKkAA== Date: Fri, 22 Mar 2024 15:58:37 +0000 Message-ID: <542b7c30-a650-471a-8030-d1d6d70cb17f@solid-run.com> References: <20240321-cn9130-som-v1-0-711127a409ae@solid-run.com> <20240321-cn9130-som-v1-2-711127a409ae@solid-run.com> <0d1afbcc-948e-4aff-8296-42f7166d318d@solid-run.com> <4fff2165-c3cc-41d8-b541-6e69ce4d98ac@lunn.ch> <748753a6-9fde-4d4f-8fee-5b93dbb532f0@solid-run.com> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=solid-run.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM9PR04MB7586:EE_|AM9PR04MB9002:EE_ x-ms-office365-filtering-correlation-id: cee79073-0d5d-4e0e-b5c1-08dc4a88ef61 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kwjTk0122ztxcIVC5yNmbYi62LONiNB8e1nh66zhElcREZQvBHZJ82GM5XvKucECdQxyMFOqrG83/VNnui4+DM/9y3e2Dyjcvi2eu4fewaOOLSdSFPgi2cx/9B0/VrFWFmQiCz1g+uSar3YvBDrYEYQ4qEz1TzKmsoH3a4DjaXOxn8s53D3HGjN8x22+ntLGKmdsKOjpBSmsQ9x6fo0js3RD0w+sZID78di/8wBlEDhEgisamdJhQH14UgFyPosLPtYDvZPFkFFtwAG/V08Ql6xR1vhymbwfcNMuej27RfTk5HldGakHL5h8KsxS/IV6njkuBYlQzj105xbwKfoW+iLQyWcErX9YhSq9nVOU1/3Khx4BFa9Y38AUsokCY3OKEgShKmryoECTocSFAGhl3dfTQgN6gBLhG8JrojBqVgx94MzyB7cQ9GytmJ97IOX8Jpa0lzVSmu1Ezxzf3rl7UPEZgLK18NDcTetVe7E+uw61ViO6gLEiZKslNKxiuD/M8wQ5KS34cNqZ0o7RnRmWH3G5GFQhiMOSPh3uYoK69zbQGunQCaKnwiKDZlmaIyr5BaTwjJCdUcsrT01ADpiWOIxxOqd8TpTimSeuEltLeptnX1v3US8TU6TbhQi3Zku5sGOaHSA03/hGZc3P9KrLC5K5ChqCBUhwSzzJrfBZd/qSMcJy290+mqAQsPhrhllOjkGLagHAddzHJcWSRbUGFg/62uvLJXzz/RsAczJFgzo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB7586.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NU1NcGFlTjQ1ekNYUTY1M0tFcmpYcDVJZFR5Y25GSUMyQU9uMWkvWkFZYmhS?= =?utf-8?B?bWVDNmxhdk1rK2RMWFZhK3JpY2F0ZW54VDg4dDRiYU00b0tnaHU3OVR3MitE?= =?utf-8?B?bU5JVFFiQlg2UXo3d3lHVURsUEt1bVJQcTN3Yi9PM0llV1dkSFAzVjluQ29M?= =?utf-8?B?SmpEMjVLSDdhTDVWZU9tZkYybmthajRWTm5yN1RSdGJBUFNxV3pQLzJDcy9i?= =?utf-8?B?amt6WmJ4UlNIV2ZnNDNveEJwS1ZOWFB5NkhTMGhPR1RBSXR4V2UyVnIrR3NV?= =?utf-8?B?Tkdta3E3czhHZzV4OXJWTU9KNUNvMnBXWDUrTWdkandKNnNOQzkxcS8yYWRF?= =?utf-8?B?N1VNK2x4MTQySFpvNE5zeXZodnBCVTZqYkVXZEJyMm1pd1Q2aHVLRnNpL1g4?= =?utf-8?B?Lzg0WUIvcTVMYjhCWjcwYURoUVoraDBxYXF0NlhqMlNMNTVieUdpdUhCcGFN?= =?utf-8?B?cnVBcUFtdVNOcm41UzI5QlU2Sks3MDRxajJOZHFCV2U1NkZHcytkZDQveGh3?= =?utf-8?B?UE5ZQ25KSGUrNE8vYnpyVTYyWVBxMU5SZmtzc3JiTW9weTUxM05NVHUyS2ty?= =?utf-8?B?NHBoWFZIRjZxRUhIbWFDbktxZTVSbUZ6Y1lOV3RkV1dUMVBtS3paOXBaL3Fn?= =?utf-8?B?dVJ3U0hxU2czMnJLeExRbjNDaUJOUkRqNVhycUlyNGFRbW1vMkp6S1NjYVlo?= =?utf-8?B?VGxEVDhaM3lPeEdKRjN4dzlDSFV4Y24xSmtnejJDVDZHOXNDdnNHSVEreXlU?= =?utf-8?B?SEE5cFZVeE9JY2hjQ0svY2J3WVA3NFQxSkdUVWNHL25UMTA1WXVaMm4yVExB?= =?utf-8?B?S3ZvZWhheFZ4ekhPK1FpWGRJS1NXenBvamFTZlpDbkNJNmc2d1p6ZkU2d0Q4?= =?utf-8?B?dDRnR3dzOFhjSEo0VEZaWTJBUng2V0M0QjZGUFF3dmxLSnF2V3F1L3cwZEtT?= =?utf-8?B?KytURnpDNll1KzVrUFBxbjFDZGlqeStkaktlck5NeHBNQlZHSlE3ejYvNFJa?= =?utf-8?B?aEczOUJrbElYbmhpZk12dVVYSE0rRnlUMG5VWWxvL0lPWUdraWFYWVJ5YlVC?= =?utf-8?B?eXhXY0UwdzBUQXVWaHNwb2c1dGVKWUtJc2szc3dsY2FmMCs5Wkt2STIzOFFt?= =?utf-8?B?U25iWmkyby9WKzVqaTBETElXeEhyeG41cTRtakszVW92Tmljc0xmRmw0QUlC?= =?utf-8?B?ZTczdTlPZmhFMk1DTFhZR0tzRkhtT1lZeTVhMjFHRXNqWm9LaTdRZ3JmeENE?= =?utf-8?B?VTh0Z2NLR2pEdkY4QWpOYjVLUTZvTWdWN0E2eUlVNWsvTklueCtQVWpOZlU3?= =?utf-8?B?bmsxR1NtdW5QVTR1Szk0WEQzWFBYbFR2cElmdlV6MDdmOExCSzRYQW82T1J2?= =?utf-8?B?elpMOEs5SVhMSUtNRE5Sa1ZjRGw1WWVndXcvWTJEV2d1RnF4YkQzZkRLWVFE?= =?utf-8?B?SXBqNlA4UThkTHpGL1lac1JsbU9ZVHZvSHJKTmlIMnBQanBNNXNqVldteGdO?= =?utf-8?B?RnN2SmJGRjcrWHkvbGxCTHQ5OXZkMUpXdDdyMkZkZ2ZScldFRkhyYmdWYnpX?= =?utf-8?B?NUxRdHVUbnR2NGdjbTV3bkxwWktZc2VqWmE5YjBqZjZzZVYzcUo0M2UwZDZo?= =?utf-8?B?elJnUTN5akw3Zjd1WWFxajdlNjFsTVlmR0FkaFh3bFg3aU9LdHZRUTEwcGMv?= =?utf-8?B?cHFzVytwYjZHeTRFa2swaWdDZGRpZFhQWU1UVURyVEIweWh1UlNkTDBtSzA5?= =?utf-8?B?NEUxbzBmYmxYeEtSM1VaYzU1UU9MdjNlcFh3NCsvYlZtMUYzL29ocGxVbHg4?= =?utf-8?B?cktLUm9CZ21GT3lwTDB3eDIwSWxoOTJwY1JSNHFkTXVrVDM2YkI0d2lSc3VX?= =?utf-8?B?ejBWb3FEbUVDSFNKdFhocW94WEZSNFZnckF1SHRtWmtqUnR1UzBmcVgwUUps?= =?utf-8?B?aUo4MWd5VWJqWUpkZjh5QUtleVZwRFg3R1NxRFBrWDQzMStjQ1JDd21sbjJR?= =?utf-8?B?VXgxVzVaK1JYSkFKMkd3cHVQVktkTTQwenN6Q3Z6NkVwNXU3aHhFMHdFUnMr?= =?utf-8?B?UVducHpwaEEvMlB1MitldmxobzcwZnd4LytQd1VjTlZuWmx1TDcvM09zUVVi?= =?utf-8?Q?J67o=3D?= Content-ID: <3E3D4D403AF420459C9F3DDE6DDFFFDC@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: solid-run.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB7586.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cee79073-0d5d-4e0e-b5c1-08dc4a88ef61 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 15:58:37.1507 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a4a8aaf3-fd27-4e27-add2-604707ce5b82 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 74CrvA7s8uRmg02ztW/LlCSrcquj6G75Fj34FJnbayWnX7MdjTMuKhLrDr2NsWBvrjVYqz5c99+EHz+2HnkqfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB9002 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_085844_134175_38EF9977 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 22.03.24 um 16:49 schrieb Andrew Lunn: >> I (currently) can't put in the led node e.g. >> linux,default-trigger = "link100|link1000|tx|rx"; >> Right? > No. The trigger will be 'netdev'. Or 'heartbeat', or > 'kbd-numlock'. OK. > They are just LEDs, they can be used for > anything. While testing some of this code i had the keyboard numlock > indicating network packets, since it easier to see than the RJ45 > socket... The same applies the other way. The RJ45 LEDs are just Linux > LEDs, they can be used for anything... > > I do have some code adding additional properties for the blink > reason. However, it is very debatable if it belongs in DT. DT > describes hardware, not configuration of hardware. > > Do you actually have labels on the case indicating what the LEDs mean? > It could be we describe the label, which is hardware, not the > configuration of the LED, which is policy from user space. I have seen it on customer products, and I have seen it in manuals, and it can help in customer support. Personally I would want it for consistency reasons, so that even if hardware engineers confused 0 and 1 I can ensure consistent behaviour out of the box. It could be the vendor recommended or intended configuration ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel