From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Tue, 07 Oct 2014 11:43:21 -0700 Subject: [PATCH 1/2] clk: Make clk API return per-user struct clk instances In-Reply-To: References: <1412255097-15928-1-git-send-email-tomeu.vizoso@collabora.com> <1412255097-15928-2-git-send-email-tomeu.vizoso@collabora.com> <20141003231515.GM10233@codeaurora.org> Message-ID: <54343449.1020605@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/07/2014 08:28 AM, Tomeu Vizoso wrote: > On 4 October 2014 01:15, Stephen Boyd wrote: >> On 10/02, Tomeu Vizoso wrote: >>> + >>> #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) >> These ifdefs look useless. >> >>> struct clk *of_clk_get_by_clkspec(struct of_phandle_args *clkspec); >>> struct clk *__of_clk_get_from_provider(struct of_phandle_args *clkspec); >>> void of_clk_lock(void); >>> void of_clk_unlock(void); >>> #endif >>> + >>> +#if defined(CONFIG_COMMON_CLK) >> So we shouldn't need this one either. > Actually, i had to put it back so clkdev.c builds on > !CONFIG_COMMON_CLK. Do you have another idea on how to deal with this? What's the error? Probably need to add a forward declaration for struct clk, struct of_phandle_args, and struct clk_hw. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation