linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: RCU bug with v3.17-rc3 ?
Date: Sat, 11 Oct 2014 14:15:37 -0400	[thread overview]
Message-ID: <543973C9.5060105@hurleysoftware.com> (raw)
In-Reply-To: <CAP9ODKrOv+_KtJDrwJ=tQCN6OrmzVopyWJKWes7vd9rKowmMjQ@mail.gmail.com>

On 10/11/2014 10:51 AM, Otavio Salvador wrote:
> Hello Russell,
> 
> On Sat, Oct 11, 2014 at 11:16 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> On Sat, Oct 11, 2014 at 11:54:32AM +0800, Peter Chen wrote:
>>> On Fri, Oct 10, 2014 at 08:44:33PM -0500, Nathan Lynch wrote:
>>>> On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote:
>>>>>
>>>>> Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and
>>>>> it seems that this has been known about for some time.)
>>>>
>>>> Looking at http://gcc.gnu.org/PR58854 it seems that all 4.8.x for x < 3
>>>> are affected, as well as 4.9.0.
>>>>
>>>>> We can blacklist these GCC versions quite easily.  We already have GCC
>>>>> 3.3 blacklisted, and it's trivial to add others.  I would want to include
>>>>> some proper details about the bug, just like the other existing entries
>>>>> we already have in asm-offsets.c, where we name the functions that the
>>>>> compiler is known to break where appropriate.
>>>>
>>>> Before blacklisting anything, it's worth considering that simple version
>>>> checks would break existing pre-4.8.3 compilers that have been patched
>>>> for PR58854.  It looks like Yocto and Buildroot issued releases with
>>>> patched 4.8.2 compilers well before the (fixed) 4.8.3 release.  I think
>>>> the most we can reasonably do without breaking some correctly-behaving
>>>> toolchains is to emit a warning.
>>>
>>> Yocto has PR58854 problem patch.
>>>
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/gcc/gcc-4.8/0048-PR58854_fix_arm_apcs_epilogue.patch?h=daisy
>>
>> Right, and we can provide links to these in the comments above the #error
>> so people have the right places to do a bit of research into whether their
>> compiler is safe.
>>
>> It is unfortunate that they are indistinguishable from the broken versions,
>> but that's really a distro problem for causing that issue themselves -
>> especially given how serious this bug is.
> 
> What about checking if GCC_PR58854_FIXED is not defined for error? So
> build systems and people could easily define it if they know their GCC
> has the fix applied.

If the distro/build system/individual is capable of patching gcc, then it
seems reasonable that the same distro/build system/individual is capable
of carrying a patch on top of mainline kernel for building with their
"special" compiler.

  reply	other threads:[~2014-10-11 18:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140904184021.GA13421@saruman.home>
     [not found] ` <20140904191642.GJ5001@linux.vnet.ibm.com>
     [not found]   ` <20140904192535.GJ13421@saruman.home>
     [not found]     ` <20140904200403.GL13421@saruman.home>
     [not found]       ` <20140905213216.GD5001@linux.vnet.ibm.com>
2014-10-08 17:13         ` RCU bug with v3.17-rc3 ? Felipe Balbi
2014-10-08 17:57           ` Felipe Balbi
2014-10-08 21:29             ` Felipe Balbi
2014-10-09 16:01               ` Johannes Weiner
2014-10-09 16:26                 ` Felipe Balbi
2014-10-09 20:35                   ` Felipe Balbi
2014-10-09 20:41                   ` Rabin Vincent
2014-10-09 20:46                     ` Felipe Balbi
2014-10-09 21:07                       ` Felipe Balbi
2014-10-10 13:57                         ` Felipe Balbi
2014-10-10 16:25                           ` Russell King - ARM Linux
2014-10-11  1:44                             ` Nathan Lynch
2014-10-11  2:40                               ` Peter Hurley
2014-10-11  3:54                               ` Peter Chen
2014-10-11 14:16                                 ` Russell King - ARM Linux
2014-10-11 14:51                                   ` Otavio Salvador
2014-10-11 18:15                                     ` Peter Hurley [this message]
2014-10-11 14:14                               ` Russell King - ARM Linux
2014-10-11 19:27                               ` Nathan Lynch
2014-10-13  9:11                               ` David Laight
2014-10-13 11:43                                 ` Russell King - ARM Linux
2014-10-14  2:06                                   ` Greg KH
2014-10-14 10:27                                     ` Peter Hurley
2014-10-15 21:23                                     ` Russell King - ARM Linux
2014-10-15 21:25                                       ` Russell King - ARM Linux
2014-10-19  9:54                                         ` Russell King - ARM Linux
2014-10-19 15:28                                           ` Felipe Balbi
2014-10-19 20:48                                             ` Olof Johansson
2014-10-09 21:47                     ` Aaro Koskinen
2014-10-10 16:18                       ` Russell King - ARM Linux
2014-10-10 20:52                         ` Aaro Koskinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543973C9.5060105@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).