From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCBC0CF2579 for ; Sun, 13 Oct 2024 10:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JO3G57aFtiKogOgwN1c2bTr04nZGHEfjrvunRtlQSSQ=; b=urw8FHDtUesyLUBQr9dVFFenfd oD+vf/K+Jf9UJ/JGUh6BPbBUh9x9oM7BYosqgchEzBe0h5+RyDTcqjGEvGNFleyDKPQafE9DAN/+l hGFNz4327DxDSSh1S1i5gjg2TOpX3WKM4YJ58oLIWJ1uY+FklzLuCeexmQiX9GcVMMQhGj6lEebOk lCFwXqiPuqaRxKew5imy9tArGpH9vg1OyN5z4wbVry6oc0p9BG3PCitfpDt1lgWZkMpBjdtsam196 9p6i9+jp3ERT5FLz9o4FbuwHMhYeM6IVo/vbp7fyR4ykele+ZKgHXYfymufwhqZK7VY7hY63zbdnV vJi9Sv+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szw8l-00000002Xm0-3oUR; Sun, 13 Oct 2024 10:47:59 +0000 Received: from mout.gmx.net ([212.227.15.18]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szw7L-00000002XZd-2IxT; Sun, 13 Oct 2024 10:46:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1728816387; x=1729421187; i=wahrenst@gmx.net; bh=JO3G57aFtiKogOgwN1c2bTr04nZGHEfjrvunRtlQSSQ=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=C8FgZAg3XBZ43s+YCfBUUFzJafiQq79lDGVTDeaVxiP8HJp1PzMdkKbVnh7khtyD 5/unSgGvWykUZIiAwocBjQW6nnYFTHQLYc0GKLRFTRHEs97NVt9yBFA2nkPdYiThr b+aF9Bq81obbgbI6V2rLnEfil3sEXvvQaxXGsPaJBQ1iTP6PsOn0MmT/loGaZSspm 3eHt6hzXXCC69GnymkxggAAyvpISsomp0uK+TAS1Bya9Gxl5Kai+aFGUWkxAby/w5 nHwsp5HpcU7Zo6wtgQQCzdTHKaW0a6S21IsBU8Ov9VaREQLnRvvkl2QJR8f8qhcJD 13LoX6B26/gfmgmd9w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.104] ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mqb1W-1tmBBD0tea-00iY7v; Sun, 13 Oct 2024 12:46:27 +0200 Message-ID: <543a2103-5e7f-4def-ad32-a1b5171ea5a7@gmx.net> Date: Sun, 13 Oct 2024 12:46:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] staging: vchiq_arm: Use devm_kzalloc for mgmt To: Umang Jain , Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Dan Carpenter , Laurent Pinchart , kernel-list@raspberrypi.com References: <20241013084529.377488-1-umang.jain@ideasonboard.com> <20241013084529.377488-3-umang.jain@ideasonboard.com> <50425e82-2a41-4a3b-a983-2560ab0ccab2@gmx.net> Content-Language: en-US From: Stefan Wahren In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:N2wB0FV26RN2dUIq6HS4z/UsLT1++9rUHs3yY5TtTsYotLDen6L C6QB3/PXIwMN3c3qb6xh2Xv91gNmFd/PGTZYdu84rHATG39sUzQ3SL/SGGEZzCXXaqfhNXi wyH74t53rhVhhtKSR1EBrO9CLV13kBx+PRpVP7hiPUZX7aKx63/+JS/IkDu8nHlAWquLMYF +ukagAY+1Ollex4jzqnwA== UI-OutboundReport: notjunk:1;M01:P0:fFiIc8b3DXU=;tl/0+GUrBrGicnYxNofFVbYLg2Q L15iOA0VXG00A9GMzEgZdfcd/g5ezj/VurxUiUYxQnmNStXQEnITm/CMTpyf/xYqz8e420jev G2IdSm7kH0uGZhmFms1fWT4+ciEEm48kuqx8rBOfP6/sbIksz1qII7aUD9i7rD/qKR+Icpcxc /L7JdUDCH2UB+i/kZmkD+9CPI1Ek6PTH/Tq6AWeWse0GXqvn3GtRj81vLYhbOcHC9WBV7p5RI JdvoqmLCmdKUWfkuCaSind71azcLIHgNQtW17lsGFGZ4F1KAOeBEsXtYSqo/SsT3duR/hlLcF w555QxC4GI4kei1O6v2gPkFZgeQXJ2s9ce3nl2eYzNZ3nhBviUYa2KicDqDoVt+RxtUZq1B9q AiTngRlSp35aPBCDtDcU1M+I7IILTA3nneordPUgIbDJ3YeSFieKdwLIQbzgc1xnwJkL968gJ VxEzQqbSTjh96w+3agvIcJB/qraszb/0ZU43iG8LXyzOiYOgJNtSHiKilwnh3LLhQCyTJ3YmW GG3o4Z6BwuofQxdPXcGEHUEbKTgxXW/4k5vXRybuD+Cy+qal/rl99TX9Ba/4glaI9k2Qjhkc7 5p4tU1WeGfKUSbr/u+TnFHx5vG83GHkcbNZyQifmobR1U3/CEImX0iDLOyNQ6HwYcjeNiXnJk XGgwuJiugeR9oSQycXWdW2wZclNE+hs5qZba+FGGOJWaMejplCK1JMiUOl9wjgvpREHn4lRVw PT+Ez3IcLWIWWqMMwdkthhukq+ZLv+lZKzyZv8acbh0+Czk7SPOOn28wvFzRp3VHRJyH27PZ+ SdkPjDk7Ro4Qer4cBZj0LTFg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241013_034631_898775_9B6239BC X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 13.10.24 um 12:36 schrieb Umang Jain: > > > On 13/10/24 2:43 pm, Stefan Wahren wrote: >> Hi Umang, >> >> Am 13.10.24 um 10:45 schrieb Umang Jain: >>> Signed-off-by: Umang Jain >> except of the missing commit message, this patch looks good to me. I >> understand the concerns about devm_kzalloc, but I think this doesn't >> apply in this case. > > That's what I was wondering as well, since I tried module unloading > and with the cdev also goes away? So shouldn't be conern, right ? AFAIU the problem would be if you bind the resources to the cdev, but this isn't the case here. Btw I missed to mention that this is considered as a fix and deserves a Fixes tag. > >> >> Since this should be treated as RFC, is it already tested? > > yes, it was tested >> >> Regards >>> --- >>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 +--- >>> =C2=A0 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git >>> a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >>> b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >>> index e780ed714a14..334fb7037766 100644 >>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >>> @@ -1345,7 +1345,7 @@ static int vchiq_probe(struct platform_device >>> *pdev) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENOENT; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> >>> -=C2=A0=C2=A0=C2=A0 mgmt =3D kzalloc(sizeof(*mgmt), GFP_KERNEL); >>> +=C2=A0=C2=A0=C2=A0 mgmt =3D devm_kzalloc(&pdev->dev, sizeof(*mgmt), G= FP_KERNEL); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!mgmt) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENOMEM; >>> >>> @@ -1403,8 +1403,6 @@ static void vchiq_remove(struct >>> platform_device *pdev) >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 arm_state =3D vchiq_platform_get_arm_st= ate(&mgmt->state); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kthread_stop(arm_state->ka_thread); >>> - >>> -=C2=A0=C2=A0=C2=A0 kfree(mgmt); >>> =C2=A0 } >>> >>> =C2=A0 static struct platform_driver vchiq_driver =3D { >> >