From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: zynq: Move common.h to generic location
Date: Mon, 20 Oct 2014 21:07:01 +0200 [thread overview]
Message-ID: <54455D55.6030003@monstr.eu> (raw)
In-Reply-To: <3225036.9QQDRKvzZS@wuerfel>
On 10/20/2014 03:36 PM, Arnd Bergmann wrote:
> On Monday 20 October 2014 15:25:31 Michal Simek wrote:
>> include/soc/zynq/ is the right location for this header
>> to be able to share information from this header with other
>> drivers which require it.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Changes in v2:
>> - Update pm.c added in 3.17 too - Soren pointed on it
>>
>> arch/arm/mach-zynq/common.c | 2 +-
>> arch/arm/mach-zynq/hotplug.c | 14 --------------
>> arch/arm/mach-zynq/platsmp.c | 2 +-
>> arch/arm/mach-zynq/pm.c | 2 +-
>> arch/arm/mach-zynq/slcr.c | 2 +-
>> {arch/arm/mach-zynq => include/soc/zynq}/common.h | 0
>> 6 files changed, 4 insertions(+), 18 deletions(-)
>> delete mode 100644 arch/arm/mach-zynq/hotplug.c
>> rename {arch/arm/mach-zynq => include/soc/zynq}/common.h (100%)
>>
>
> NAK
>
> Most (if not all) of that header should not be visible to drivers.
> If you need to share some symbols, make a proper header file for those,
> not one called 'common.h'.
Ok. I will split it to more files - no problem to do it.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141020/a5a4c926/attachment.sig>
prev parent reply other threads:[~2014-10-20 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 13:25 [PATCH v2 1/3] ARM: zynq: Move common.h to generic location Michal Simek
2014-10-20 13:25 ` [PATCH v2 2/3] ARM: zynq: Enable generic allocator Michal Simek
2014-10-20 13:34 ` Arnd Bergmann
2014-10-20 14:10 ` Michal Simek
2014-10-20 13:25 ` [PATCH v2 3/3] ARM: zynq: Extend SLCR driver to read OCM configuration Michal Simek
2014-10-20 13:36 ` [PATCH v2 1/3] ARM: zynq: Move common.h to generic location Arnd Bergmann
2014-10-20 19:07 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54455D55.6030003@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).