linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: smoch@web.de (Sören Moch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: add initial support for TBS2910 Matrix ARM mini PC
Date: Tue, 21 Oct 2014 13:57:46 +0200	[thread overview]
Message-ID: <54464A3A.2070003@web.de> (raw)
In-Reply-To: <54460DD5.5010908@gmail.com>

Sebastian,

Thanks for your review.

>> +/ {
>> +    model = "TBS2910 Matrix ARM mini PC";
>> +    compatible = "tbs,imx6q-tbs2910", "fsl,imx6q";
>
> [...]
> Also, board compatible should only be "tbs,tbs2910".

Similar boards use e.g.
	compatible = "fsl,imx6q-sabresd", "fsl,imx6q";
	compatible = "udoo,imx6q-udoo", "fsl,imx6q";
	compatible = "wand,imx6q-wandboard", "fsl,imx6q";

So is it really better to use only "tbs,tbs2910" here?

Soeren

  reply	other threads:[~2014-10-21 11:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-18 12:27 [PATCH] arm: dts: add initial support for TBS2910 Matrix ARM mini PC Soeren Moch
2014-10-21  7:40 ` Sebastian Hesselbarth
2014-10-21 11:57   ` Sören Moch [this message]
2014-10-21 12:03     ` Sebastian Hesselbarth
2014-10-21 14:17       ` Sascha Hauer
2014-10-21 18:25         ` Sebastian Hesselbarth
2014-10-21 20:23 ` [PATCH v2] " Soeren Moch
2014-10-25 15:33   ` Shawn Guo
2014-10-25 17:50     ` Soeren Moch
2014-10-25 18:51       ` Sebastian Hesselbarth
2014-10-26  0:15       ` Shawn Guo
2014-10-26  0:55   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54464A3A.2070003@web.de \
    --to=smoch@web.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).