* [PATCH] power: reset: at91-reset: fix power down register
@ 2014-10-20 18:27 Alexandre Belloni
2014-10-21 14:18 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2014-10-20 18:27 UTC (permalink / raw)
To: linux-arm-kernel
In the case of at91sam9g45_restart(), the driver is writing
AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be
AT91_DDRSDRC_LPR.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/power/reset/at91-reset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
index 3611806c9cfd..3cb36693343a 100644
--- a/drivers/power/reset/at91-reset.c
+++ b/drivers/power/reset/at91-reset.c
@@ -100,11 +100,11 @@ static void at91sam9g45_restart(enum reboot_mode mode, const char *cmd)
/* Disable SDRAM0 accesses */
"1: str %3, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
/* Power down SDRAM0 */
- " str %4, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
+ " str %4, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
/* Disable SDRAM1 accesses */
" strne %3, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
/* Power down SDRAM1 */
- " strne %4, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
+ " strne %4, [%1, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
/* Reset CPU */
" str %5, [%2, #" __stringify(AT91_RSTC_CR) "]\n\t"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] power: reset: at91-reset: fix power down register
2014-10-20 18:27 [PATCH] power: reset: at91-reset: fix power down register Alexandre Belloni
@ 2014-10-21 14:18 ` Nicolas Ferre
2014-10-21 14:46 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Ferre @ 2014-10-21 14:18 UTC (permalink / raw)
To: linux-arm-kernel
On 20/10/2014 20:27, Alexandre Belloni :
> In the case of at91sam9g45_restart(), the driver is writing
> AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be
> AT91_DDRSDRC_LPR.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Absolutely:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
If you don't mind Dmitry, I'll take this patch through the at91/arm-soc
git trees in my next at91-3.18-fixes branch.
Thanks Alex, bye,
> ---
> drivers/power/reset/at91-reset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c
> index 3611806c9cfd..3cb36693343a 100644
> --- a/drivers/power/reset/at91-reset.c
> +++ b/drivers/power/reset/at91-reset.c
> @@ -100,11 +100,11 @@ static void at91sam9g45_restart(enum reboot_mode mode, const char *cmd)
> /* Disable SDRAM0 accesses */
> "1: str %3, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> /* Power down SDRAM0 */
> - " str %4, [%0, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> + " str %4, [%0, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
> /* Disable SDRAM1 accesses */
> " strne %3, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> /* Power down SDRAM1 */
> - " strne %4, [%1, #" __stringify(AT91_DDRSDRC_RTR) "]\n\t"
> + " strne %4, [%1, #" __stringify(AT91_DDRSDRC_LPR) "]\n\t"
> /* Reset CPU */
> " str %5, [%2, #" __stringify(AT91_RSTC_CR) "]\n\t"
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] power: reset: at91-reset: fix power down register
2014-10-21 14:18 ` Nicolas Ferre
@ 2014-10-21 14:46 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2014-10-21 14:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, Oct 21, 2014 at 04:18:34PM +0200, Nicolas Ferre wrote:
> On 20/10/2014 20:27, Alexandre Belloni :
> > In the case of at91sam9g45_restart(), the driver is writing
> > AT91_DDRSDRC_LPCB_POWER_DOWN to AT91_DDRSDRC_RTR, this should actually be
> > AT91_DDRSDRC_LPR.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> Absolutely:
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> If you don't mind Dmitry, I'll take this patch through the at91/arm-soc
> git trees in my next at91-3.18-fixes branch.
Acked-by: Sebastian Reichel <sre@kernel.org>
P.S.: Please update your MAINTAINERS file.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141021/9f2aa6fc/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-21 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-20 18:27 [PATCH] power: reset: at91-reset: fix power down register Alexandre Belloni
2014-10-21 14:18 ` Nicolas Ferre
2014-10-21 14:46 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).