[PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes

[PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes

[Ezequiel Garcia]

Jason,

On 25 Sep 01:17 PM, Grzegorz Jaszczyk wrote:
> This patchset contains a set of fixes for issues found while doing some test
> with different interrupts configuration on Armada 375 and Armada 38x Marvell
> SoCs. The patches were tested and apply on v3.17-rc6.
> 
> Any feedback is welcome.
> 
> Grzegorz Jaszczyk (2):
>   irqchip: armada-370-xp: fix MSI interrupt handling
>   irqchip: armada-370-xp: fix MPIC interrupt handling

The second patch fixes an unhandled IRQ storm triggered by the mvpp2
ethernet driver, when the kernel is built with CONFIG_SMP=n.

When any network activity is attempted the kernel is interrupted by a per-cpu 
IRQ (which is not the one the driver expects). The interrupt is not mapped 
into Linux's virtual IRQ space, so the result is:

  irq 0, desc: ee004000, depth: 1, count: 0, unhandled: 0
  ->handle_irq():  c00466e8, handle_bad_irq+0x0/0x260
  ->irq_data.chip(): c1181460, 0xc1181460
  ->action():   (null)
     IRQ_NOPROBE set
   IRQ_NOREQUEST set

For both patches:

Fixes: bc69b8adfe22 ("irqchip: armada-370-xp: Setup a chained handler for the MPIC")
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

Thanks,
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

[PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes

[Jason Cooper]

On Thu, Sep 25, 2014 at 01:17:17PM +0200, Grzegorz Jaszczyk wrote:
> This patchset contains a set of fixes for issues found while doing some test
> with different interrupts configuration on Armada 375 and Armada 38x Marvell
> SoCs. The patches were tested and apply on v3.17-rc6.
> 
> Any feedback is welcome.
> 
> Grzegorz Jaszczyk (2):
>   irqchip: armada-370-xp: fix MSI interrupt handling
>   irqchip: armada-370-xp: fix MPIC interrupt handling
> 
>  drivers/irqchip/irq-armada-370-xp.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)

Ah crap.  This slipped off my plate.  Sorry about that.  I've now
applied these to irqchip/urgent with Ezequiel's Ack.  I'll get them into
-next and hopefully do a PR toward the end of next week.

thx,

Jason.

[PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes

[Ezequiel Garcia]

On 10/03/2014 10:50 AM, Jason Cooper wrote:
> On Thu, Sep 25, 2014 at 01:17:17PM +0200, Grzegorz Jaszczyk wrote:
>> This patchset contains a set of fixes for issues found while doing some test
>> with different interrupts configuration on Armada 375 and Armada 38x Marvell
>> SoCs. The patches were tested and apply on v3.17-rc6.
>>
>> Any feedback is welcome.
>>
>> Grzegorz Jaszczyk (2):
>>   irqchip: armada-370-xp: fix MSI interrupt handling
>>   irqchip: armada-370-xp: fix MPIC interrupt handling
>>
>>  drivers/irqchip/irq-armada-370-xp.c | 23 +++++++++++++++++------
>>  1 file changed, 17 insertions(+), 6 deletions(-)
> 
> Ah crap.  This slipped off my plate.  Sorry about that.  I've now
> applied these to irqchip/urgent with Ezequiel's Ack.  I'll get them into
> -next and hopefully do a PR toward the end of next week.
> 

Jason,

The patches don't seem to be in v3.18-rc1 for some reason.

I can't seem to find your PR (probably because I've switched to
Thunderbird now
and it's a pain to search mails properly).

Since this is an important fix, maybe you can schedule it for -rc2?

Thanks!
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

[PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes

[Jason Cooper]

On Tue, Oct 21, 2014 at 11:19:31AM -0300, Ezequiel Garcia wrote:
> On 10/03/2014 10:50 AM, Jason Cooper wrote:
> > On Thu, Sep 25, 2014 at 01:17:17PM +0200, Grzegorz Jaszczyk wrote:
> >> This patchset contains a set of fixes for issues found while doing some test
> >> with different interrupts configuration on Armada 375 and Armada 38x Marvell
> >> SoCs. The patches were tested and apply on v3.17-rc6.
> >>
> >> Any feedback is welcome.
> >>
> >> Grzegorz Jaszczyk (2):
> >>   irqchip: armada-370-xp: fix MSI interrupt handling
> >>   irqchip: armada-370-xp: fix MPIC interrupt handling
> >>
> >>  drivers/irqchip/irq-armada-370-xp.c | 23 +++++++++++++++++------
> >>  1 file changed, 17 insertions(+), 6 deletions(-)
> > 
> > Ah crap.  This slipped off my plate.  Sorry about that.  I've now
> > applied these to irqchip/urgent with Ezequiel's Ack.  I'll get them into
> > -next and hopefully do a PR toward the end of next week.
> > 
> 
> Jason,
> 
> The patches don't seem to be in v3.18-rc1 for some reason.

Correct.

> I can't seem to find your PR (probably because I've switched to
> Thunderbird now
> and it's a pain to search mails properly).

Some folks seem to like Claws.  There hasn't been a PR yet, though.

> Since this is an important fix, maybe you can schedule it for -rc2?

I have.  For some reason I have yet to delve into, there were no
linux-next's during the merge window.  As a result, yesterday's -next
was the first for the two patches in question.  I'd like to get them
pushed for -rc2, so I'll probably send the PR tomorrow to get one more
day in -next.

thx,

Jason.

[PATCH 0/2] Marvell Armada 375/38x MPIC/MSI fixes

[Ezequiel Garcia]

On 10/21/2014 12:14 PM, Jason Cooper wrote:
[..]
> 
>> Since this is an important fix, maybe you can schedule it for -rc2?
> 
> I have.  For some reason I have yet to delve into, there were no
> linux-next's during the merge window.  As a result, yesterday's -next
> was the first for the two patches in question.  I'd like to get them
> pushed for -rc2, so I'll probably send the PR tomorrow to get one more
> day in -next.
> 

Great, thanks!
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com